Skip to content

[HOLD for payment 2024-11-07] Unable to run storybook locally #51108

Closed

Description

@chiragsalian

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C02NK2DQWUX/p1727459623902909

Action Performed:

npm run storybook

Expected Result:

storybook should have opened without any issues

Actual Result:

Bunch of errors locally
image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

cc @ishpaul777

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 18, 2024
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 18, 2024
  3. melvin-bot commented on Oct 18, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  4. melvin-bot commented on Oct 18, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. luckydaniel1993 commented on Oct 19, 2024

    @luckydaniel1993

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to run storybook locally

    What is the root cause of that problem?

    The “cannot access before initialization” error occurs when you try to use a variable before it has been initialized.

    What changes do you think we should make in order to solve the problem?

    We should declare and initialize the variable before we use it.
    The solution is to change this part.

    let Link, LinkingContext, NavigationContainer, ServerContainer, DarkTheme, DefaultTheme, ThemeProvider, useLinkBuilder, useLinkProps, useLinkTo, useScrollToTop;
    Link = realReactNavigation.Link;
    LinkingContext = realReactNavigation.LinkingContext;
    NavigationContainer = realReactNavigation.NavigationContainer;
    ServerContainer = realReactNavigation.ServerContainer;
    DarkTheme = realReactNavigation.DarkTheme;
    DefaultTheme = realReactNavigation.DefaultTheme;
    ThemeProvider = realReactNavigation.ThemeProvider;
    useLinkBuilder = realReactNavigation.useLinkBuilder;
    useLinkProps = realReactNavigation.useLinkProps;
    useLinkTo = realReactNavigation.useLinkTo;
    useScrollToTop = realReactNavigation.useScrollToTop;
    

    What alternative solutions did you explore? (Optional)

    N/A

    Contributor details

    Your Expensify account email: anasup1995@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

  6. melvin-bot commented on Oct 19, 2024

    @melvin-bot

    📣 @anaslancer! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  7. luckydaniel1993 commented on Oct 19, 2024

    @luckydaniel1993

    Screenshot_4

  8. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    @trjExpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. 39 remaining items

  10. ishpaul777 commented on Nov 9, 2024

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: Agency Member
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/41962/files#r1835364153

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Not possible for QA to test storybook this as of now

  11. trjExpensify commented on Nov 12, 2024

    @trjExpensify
    Contributor

    Payment summary as follows:

    @anaslancer can you link your Upwork profile, please? @ishpaul777, offer sent.

  12. luckydaniel1993 commented on Nov 12, 2024

    @luckydaniel1993
  13. trjExpensify commented on Nov 12, 2024

    @trjExpensify
    Contributor

    Thanks, sent you an offer!

    Separately, was this you testing in the #exfy-roadmap public room earlier today?

    image
  14. luckydaniel1993 commented on Nov 12, 2024

    @luckydaniel1993

    Yes, it was me and deleted all test message.

  15. luckydaniel1993 commented on Nov 12, 2024

    @luckydaniel1993

    There is any way to test on public room?
    I am using the staging database.

  16. luckydaniel1993 commented on Nov 12, 2024

    @luckydaniel1993

    Thank you for your offer and accepted :)

  17. trjExpensify commented on Nov 12, 2024

    @trjExpensify
    Contributor

    Yes, it was me and deleted all test message.

    Thanks for confirming! Please don't use any of the EXFY owned public rooms for testing. They include real customers and investors.

    There is any way to test on public room?

    You can create your own, but feel free to use this testing one as well: https://staging.new.expensify.com/r/2091104345528462

  18. trjExpensify commented on Nov 12, 2024

    @trjExpensify
    Contributor

    Thank you for your offer and accepted :)

    Paid, @anaslancer. @ishpaul777 waiting on you to accept your offer now as well.

  19. trjExpensify commented on Nov 15, 2024

    @trjExpensify
    Contributor
  20. ishpaul777 commented on Nov 15, 2024

    @ishpaul777
    Contributor

    I just landed 🛬 in my home city was OOO past few days will be catching up on overdue things soon, Thanks for bump and sorry for delay

  21. ishpaul777 commented on Nov 17, 2024

    @ishpaul777
    Contributor

    I have accepted the offfer 🙇

  22. trjExpensify commented on Nov 18, 2024

    @trjExpensify
    Contributor

    Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions