Skip to content

[Hold for #50796] [$250] Contact method - User returned to enter new email step after backgrounding app #51275

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.52.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49445

Action Performed:

  1. Open the app and log in
  2. Navigate to the account settings > Profile > Contact method
  3. Tap the New contact method button
  4. Enter an email that will be used as a secondary login and proceed to the magic code step
  5. Background the app
  6. Open the app again

Expected Result:

User lands back on the magic code step

Actual Result:

User is returned to the enter email step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6642192_1729610713546.video_2024-10-22_11-24-57.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848841356939319972
  • Upwork Job ID: 1848841356939319972
  • Last Price Increase: 2024-10-22
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2024
  2. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lanitochka17 commented on Oct 22, 2024

    @lanitochka17
    Author

    Production:

    -7479549786383612484.MP4
  7. daledah commented on Oct 22, 2024

    @daledah
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-10-22 17:21:18 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User is returned to the enter email step

    What is the root cause of that problem?

    we don't change route when we navigate to verify steps

    What changes do you think we should make in order to solve the problem?

    1. We should add new route for this page like we did with Add bank account
        SETTINGS_NEW_CONTACT_METHOD_VERIFY: {
            route: 'settings/profile/contact-methods/new/verify',
            getRoute: (backTo?: string) => getUrlWithBackToParam('settings/profile/contact-methods/new/verify', backTo),
        },
    
    1. And move this modal to the new page

    <ValidateCodeActionModal
    validatePendingAction={pendingContactAction?.pendingFields?.actionVerified}
    validateError={validateLoginError}
    handleSubmitForm={addNewContactMethod}

    What alternative solutions did you explore? (Optional)

    We can customize VerifyAccountPage component to match the requirements on the contact page.

  8. srikarparsi commented on Oct 22, 2024

    @srikarparsi
    Contributor

    Related PR

  9. 39 remaining items

  10. moved this to Bugs and Follow Up Issues in #expensify-bugson Nov 19, 2024
  11. sonialiap commented on Nov 20, 2024

    @sonialiap
    Contributor

    Still on hold for #50796

  12. removed their assignment
    on Nov 20, 2024
  13. kadiealexander commented on Nov 29, 2024

    @kadiealexander
    Contributor

    Requested a retest here

  14. izarutskaya commented on Nov 29, 2024

    @izarutskaya

    Issue is not reproducible
    Build 9.0.68-5

    Screen_Recording_20241129_181243_Gmail.mp4
  15. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions