You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup #51277
Version Number: 9.0.52-2 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):yonghongkok2+ksopdspd11@gmail.com Issue reported by: Applause Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/-][+][HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/+]on Oct 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@francoisl] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@francoisl] Determine if we should create a regression test for this bug.
[@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
francoisl commentedon Oct 22, 2024
I can repro, there are 2 API calls to
RequestContactMethodValidateCodewhen you click "or verify your account here".This might possibly be coming from #49445, discussion about a fix ongoing in https://expensify.slack.com/archives/C01GTK53T8Q/p1729607715820819.
francoisl commentedon Oct 22, 2024
This will be fixed by #51267
11 remaining items
yuwenmemon commentedon Oct 23, 2024
https://expensify.slack.com/archives/C07J32337/p1729726700727579
RachCHopkins commentedon Oct 24, 2024
@francoisl Do I need to pay anyone here?
[-][HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/-][+][HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/+]melvin-bot commentedon Oct 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-01. 🎊
melvin-bot commentedon Oct 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Nov 1, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Nov 1, 2024
@francoisl, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!
francoisl commentedon Nov 1, 2024
I don't believe so, the PR fixed multiple issues, and this one already has a payment summary for the C+ that reviewed.