Skip to content

[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup #51277

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): yonghongkok2+ksopdspd11@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account (unvalidated).
  3. Complete the onboarding.
  4. Create a new workspace.
  5. Go to workspace settings > More features.
  6. Enable Workflows.
  7. Go to Workflows.
  8. Click Connect bank account.
  9. Click "verify your account here" link.
  10. Check email.

Expected Result:

One magic code email will be received.

Actual Result:

One magic code email will be received.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6642324_1729615954448.20241023_004923.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @francoisl

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2024
  2. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. francoisl commented on Oct 22, 2024

    @francoisl
    Contributor

    I can repro, there are 2 API calls to RequestContactMethodValidateCode when you click "or verify your account here".

    image

    This might possibly be coming from #49445, discussion about a fix ongoing in https://expensify.slack.com/archives/C01GTK53T8Q/p1729607715820819.

  7. francoisl commented on Oct 22, 2024

    @francoisl
    Contributor

    This will be fixed by #51267

  8. 11 remaining items

  9. yuwenmemon commented on Oct 23, 2024

    @yuwenmemon
    Contributor
  10. RachCHopkins commented on Oct 24, 2024

    @RachCHopkins
    Contributor

    @francoisl Do I need to pay anyone here?

  11. changed the title [-][HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/-] [+][HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup[/+] on Oct 25, 2024
  12. melvin-bot commented on Oct 25, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-01. 🎊

  13. melvin-bot commented on Oct 25, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
    • [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@francoisl] Determine if we should create a regression test for this bug.
    • [@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    @francoisl, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. francoisl commented on Nov 1, 2024

    @francoisl
    Contributor

    I don't believe so, the PR fixed multiple issues, and this one already has a payment summary for the C+ that reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions