You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Search - Tooltip is not displayed on the new Saved search indicating the name can be edited #51531
Version Number: 9.0.54-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/cases/view/3284916 Issue reported by: Applause - Internal Team
Action Performed:
Go to the Search page
Click on the filter icon
Set a filter for the category “Advertising”
Click on Save > Save Search button
Expected Result:
A new “Saved” section is displayed on the Search page navigation.
A tooltip is displayed on the new Saved search indicating the name can be edited
Actual Result:
A tooltip is not displayed on the new Saved search indicating the name can be edited
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6646602_1729941344494.no_tooltip.mp4
// We only want to show the tooltip once, the NVP will not be set if the user has not saved a search yet
if(!savedSearches){
SearchActions.showSavedSearchRenameTooltip();
}
What changes do you think we should make in order to solve the problem?
if we want to show the tooltip each time a user save the search , we can remove the condition, and directly write: SearchActions.showSavedSearchRenameTooltip();
I'm not sure I understand the problem, the video doesn't match the steps in the OP. What are we trying to solve? Where is the 'tooltip' - do you mean the hamburger with the option to Rename?
Can you confirm that we want the tooltip to show on a saved search? From what I can tell, the tooltip doesn't show with any desktop version so I just want to make sure we want it.
Here's an image of the tooltip that we're referring to
@izarutskaya the tooltip should only be shown the first time ever you save a search. So if you are testing on an existing account that has already saved a search in the past (even though all saved searches are deleted), we should NOT show the tooltip again. Hope that clarifies things.
Activity
melvin-bot commentedon Oct 26, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 26, 2024
We think that this bug might be related to #wave-control
Shahidullah-Muffakir commentedon Oct 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip is not displayed on the saved search.
What is the root cause of that problem?
we are only showing the tooltip once, based on this comment and code:
App/src/pages/Search/AdvancedSearchFilters.tsx
Lines 290 to 293 in 652d2ff
What changes do you think we should make in order to solve the problem?
if we want to show the tooltip each time a user save the search , we can remove the condition, and directly write:
SearchActions.showSavedSearchRenameTooltip();Screen.20Recording.202024-10-27.20at.201.mp4
Christinadobrzyn commentedon Oct 28, 2024
Gonna test this tomorrow when I'm back from ooo
FitseTLT commentedon Oct 28, 2024
Looks like intentional
App/src/pages/Search/AdvancedSearchFilters.tsx
Lines 290 to 293 in 652d2ff
Christinadobrzyn commentedon Oct 29, 2024
I'm not sure I understand the problem, the video doesn't match the steps in the OP. What are we trying to solve? Where is the 'tooltip' - do you mean the hamburger with the option to Rename?
https://expensify.slack.com/archives/C9YU7BX5M/p1730168405943419
izarutskaya commentedon Oct 29, 2024
We refer to #49473 and expect to see this tooltip
Let me know if I can help something else
Christinadobrzyn commentedon Oct 30, 2024
Ah okay, I don't see that is possible in https://staging.new.expensify.com/ either.
I'll ask one more question in the QA chat, and then I'll reach out to the team to see if we want this.
izarutskaya commentedon Oct 30, 2024
We tested step by step in TR and step 8 says that
Verify a tooltip is displayed on the new Saved search indicating the name can be editedScreenshot with tooltip from this PR and you will see link with PR at the bottom of the page in "Comments or Known issue".
Check please TR link. Thanks
Christinadobrzyn commentedon Oct 31, 2024
Amazing! Thank you for all the information @izarutskaya!
@lanitochka17 and @luacmartins since you were part of this issue
Can you confirm that we want the tooltip to show on a saved search? From what I can tell, the tooltip doesn't show with any desktop version so I just want to make sure we want it.
Here's an image of the tooltip that we're referring to
#51531 (comment)
Thanks!
luacmartins commentedon Oct 31, 2024
@izarutskaya the tooltip should only be shown the first time ever you save a search. So if you are testing on an existing account that has already saved a search in the past (even though all saved searches are deleted), we should NOT show the tooltip again. Hope that clarifies things.
Christinadobrzyn commentedon Nov 1, 2024
Thanks @luacmartins - I think this is happening as expected but asking @izarutskaya if they can double-check - https://expensify.slack.com/archives/C9YU7BX5M/p1730441140139549?thread_ts=1730168405.943419&cid=C9YU7BX5M
izarutskaya commentedon Nov 1, 2024
Yes, I have this tooltip in new account when save a search at first time, than no tooltip when I change the search
Recording.2890.mp4
luacmartins commentedon Nov 1, 2024
Cool, seems like we can close this one then.