Skip to content

[HOLD for payment 2024-12-05] [$250] Trackpad gestures for navigation history does not work in Newdot #51704

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.55-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1730106001602619

Action Performed:

  1. Open ND on web chrome (Macos), navigate to different pages, to. build navigation history.
  2. Swipe right with 2 fingers on trackpad to navigate back

Expected Result:

It navigate back to previous page like other apps

Actual Result:

Nothing happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.3168.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021852208286215064025
  • Upwork Job ID: 1852208286215064025
  • Last Price Increase: 2024-11-08
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 29, 2024
  2. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Oct 30, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    2-finger swipe gesture doesn't work in web.

    What is the root cause of that problem?

    The gesture doesn't work because we disable the overscroll-behavior here.

    App/web/index.html

    Lines 37 to 41 in fe779d9

    body {
    overflow: hidden;
    overscroll-behavior: none;
    touch-action: none;
    }

    This was added in #15100 to specifically not allow the body to be scrollable on iOS safari.

    What changes do you think we should make in order to solve the problem?

    We should disable the overscroll-behavior (and touch-action if needed) for iOS safari only. First, remove it from here.

    App/web/index.html

    Lines 37 to 41 in fe779d9

    body {
    overflow: hidden;
    overscroll-behavior: none;
    touch-action: none;
    }

    Then, add a new selector style to disable overscroll-behavior.

    body.disable-overscroll {
        overscroll-behavior: none;
    }
    

    Last, apply the class to the body if it's mobile safari. (we can apply this in App.tsx)

    if (isMobileSafari()) document.body.classList.add('disable-overscroll')
    

    What alternative solutions did you explore? (Optional)

    Remove the overscroll-behavior and touch-action hack just like we remove the opacity hack from #15100 in #18266.

  4. VictoriaExpensify commented on Nov 1, 2024

    @VictoriaExpensify
    Contributor

    Reproduced the issue. I agree this is a problem we should fix

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 1, 2024
  6. changed the title [-]Trackpad gestures for navigation history does not work in Newdot[/-] [+][$250] Trackpad gestures for navigation history does not work in Newdot[/+] on Nov 1, 2024
  7. melvin-bot commented on Nov 1, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 1, 2024
  9. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  10. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    @mananjadhav, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. 26 remaining items

  12. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
    • @ishpaul777 requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    @mananjadhav @VictoriaExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Dec 3, 2024
  16. mananjadhav commented on Dec 4, 2024

    @mananjadhav
    Collaborator

    BugZero Checklist:

    • [Contributor] Classify the bug:

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user

    • 3b. Expensify employee

    • 3c. Contributor

    • 3d. QA

    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Fix: iOS autoscroll when <input/> is focused #15100 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Gestures available only on web:

    Test:

    1. Navigate to any page
    2. Swipe to left
    3. Verify it navigates back
    4. Swipe to right
    5. Verify it navigates forward

    Do we agree 👍 or 👎

  17. bernhardoj commented on Dec 5, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  18. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@VictoriaExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1852208286215064025/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  19. VictoriaExpensify commented on Dec 6, 2024

    @VictoriaExpensify
    Contributor

    Raised issue to add the regression test to test rail - https://github.com/Expensify/Expensify/issues/451044

  20. VictoriaExpensify commented on Dec 6, 2024

    @VictoriaExpensify
    Contributor

    Payment Summary:
    Upwork Job

    Reviewer: @mananjadhav owed $250 via NewDot
    Reviewer: @bernhardoj owed $250 via NewDot

  21. moved this from Hold for Payment to Done in #expensify-bugson Dec 6, 2024
  22. JmillsExpensify commented on Dec 6, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  23. garrettmknight commented on Dec 10, 2024

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions