You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-05] [$250] Trackpad gestures for navigation history does not work in Newdot #51704
changed the title [-]Trackpad gestures for navigation history does not work in Newdot[/-][+][$250] Trackpad gestures for navigation history does not work in Newdot[/+]on Nov 1, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@VictoriaExpensify@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 29, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Oct 30, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
2-finger swipe gesture doesn't work in web.
What is the root cause of that problem?
The gesture doesn't work because we disable the
overscroll-behaviorhere.App/web/index.html
Lines 37 to 41 in fe779d9
This was added in #15100 to specifically not allow the body to be scrollable on iOS safari.
What changes do you think we should make in order to solve the problem?
We should disable the overscroll-behavior (and touch-action if needed) for iOS safari only. First, remove it from here.
App/web/index.html
Lines 37 to 41 in fe779d9
Then, add a new selector style to disable
overscroll-behavior.Last, apply the class to the body if it's mobile safari. (we can apply this in App.tsx)
What alternative solutions did you explore? (Optional)
Remove the overscroll-behavior and touch-action hack just like we remove the opacity hack from #15100 in #18266.
VictoriaExpensify commentedon Nov 1, 2024
Reproduced the issue. I agree this is a problem we should fix
[-]Trackpad gestures for navigation history does not work in Newdot[/-][+][$250] Trackpad gestures for navigation history does not work in Newdot[/+]melvin-bot commentedon Nov 1, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021852208286215064025
melvin-bot commentedon Nov 1, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Nov 4, 2024
@mananjadhav, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
26 remaining items
melvin-bot commentedon Nov 28, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 28, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 28, 2024
@mananjadhav @VictoriaExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mananjadhav commentedon Dec 4, 2024
BugZero Checklist:
Source of bug:
Where bug was reported:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Fix: iOS autoscroll when
<input/>is focused #15100 (comment)[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
bernhardoj commentedon Dec 5, 2024
Requested in ND.
melvin-bot commentedon Dec 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@VictoriaExpensify)
VictoriaExpensify commentedon Dec 6, 2024
Raised issue to add the regression test to test rail - https://github.com/Expensify/Expensify/issues/451044
VictoriaExpensify commentedon Dec 6, 2024
Payment Summary:
Upwork Job
Reviewer: @mananjadhav owed $250 via NewDot
Reviewer: @bernhardoj owed $250 via NewDot
JmillsExpensify commentedon Dec 6, 2024
$250 approved for @bernhardoj
garrettmknight commentedon Dec 10, 2024
$250 approved for @mananjadhav