You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-13] [$250] Implement tests for reports that should not be displayed in LHN #52034
changed the title [-]Implement tests for reports that should not be displayed in LHN[/-][+][HOLD App#52036]Implement tests for reports that should not be displayed in LHN[/+]on Nov 5, 2024
changed the title [-][HOLD App#52036]Implement tests for reports that should not be displayed in LHN[/-][+][HOLD App#52036] Implement tests for reports that should not be displayed in LHN[/+]on Nov 5, 2024
Please re-state the problem that we are trying to solve in this issue.
Implement tests for reports that should not be displayed in LHN.
What is the root cause of that problem?
This is the first time we're adding these tests.
What changes do you think we should make in order to solve the problem?
Example of 1 test for reference:
it('should not display hidden report',async()=>{// When the SidebarLinks are rendered.awaitLHNTestUtils.getDefaultRenderedSidebarLinks();constreport=createReport({isHidden: false});// And a non-hidden report is initialized in Onyx.awaitinitializeState(false,{[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,});// Then the report should appear in the sidebar.expect(getOptionRows()).toHaveLength(1);// When the report is hidden.awaitact(async()=>{awaitOnyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,{isHidden: true});});// Then the report should not appear in the sidebar.expect(getOptionRows()).toHaveLength(0);});
A few more can be found on my test branch. It also includes fixes for console errors that appeared while running these tests, e.g. missing key prop and missing act() calls.
Todo: check not only for the count of reports but also validate the name, etc.
Update: Waiting for this one to go into production
Heads up, I will be offline until Friday, January 3, 2025, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.
changed the title [-][$250] Implement tests for reports that should not be displayed in LHN[/-][+][HOLD for payment 2025-01-13] [$250] Implement tests for reports that should not be displayed in LHN[/+]on Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@c3024@alexpensify@c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Nov 5, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Implement tests for reports that should not be displayed in LHN[/-][+][HOLD App#52036]Implement tests for reports that should not be displayed in LHN[/+][-][HOLD App#52036]Implement tests for reports that should not be displayed in LHN[/-][+][HOLD App#52036] Implement tests for reports that should not be displayed in LHN[/+]alexpensify commentedon Nov 7, 2024
Moving to Weekly since we are on hold for App#52036
Heads up, I will be offline until Tuesday, November 12, 2024, and will not actively watch over this GitHub during that period.
alexpensify commentedon Nov 19, 2024
Still on hold for App#52036
alexpensify commentedon Nov 25, 2024
On hold
andriivitiv commentedon Nov 25, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Implement tests for reports that should not be displayed in LHN.
What is the root cause of that problem?
This is the first time we're adding these tests.
What changes do you think we should make in order to solve the problem?
Example of 1 test for reference:
A few more can be found on my test branch. It also includes fixes for console errors that appeared while running these tests, e.g. missing
keyprop and missingact()calls.Todo: check not only for the count of reports but also validate the name, etc.
43 remaining items
alexpensify commentedon Dec 24, 2024
Weekly Update: PR is moving along through the review process
alexpensify commentedon Dec 30, 2024
Update: Waiting for this one to go into production
Heads up, I will be offline until Friday, January 3, 2025, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.
[-][$250] Implement tests for reports that should not be displayed in LHN[/-][+][HOLD for payment 2025-01-13] [$250] Implement tests for reports that should not be displayed in LHN[/+]melvin-bot commentedon Jan 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 6, 2025
@c3024 @alexpensify @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
alexpensify commentedon Jan 14, 2025
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @c3024 paid $250 via Upwork since it's before the 11/28 date
--
Closing - everyone has been paid via Upwork