Skip to content

[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens #52045

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.57-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): yonghongkok2+22skdpsdkok@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Sign up as a new Gmail user
  3. Complete onboarding
  4. Create a new workspace
  5. Go to workspace settings > More features
  6. Enable Workflows
  7. Go to Workflows
  8. Click Connect bank account
  9. Click Connect online with Plaid
  10. Enter magic code

Expected Result:

After entering magic code from Connect online with Plaid, Plaid page will open

Actual Result:

After entering magic code from Connect online with Plaid, "Manually add bank account" page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6655471_1730812610903.bandicam_2024-11-05_21-10-35-451.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853831016472532052
  • Upwork Job ID: 1853831016472532052
  • Last Price Increase: 2024-11-05
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Nov 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. Nodebrute commented on Nov 5, 2024

    @Nodebrute
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-11-05 15:00:09 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After entering magic code from Connect online with Plaid, manual set up opens

    What is the root cause of that problem?

    Here we set the subset to MANUAL That is why after verification we navigate to manual page

    selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL;

    I can see that this is also wrong the below code should be MANUAL
    selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID;

    What changes do you think we should make in order to solve the problem?

    Change this to CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID

    selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL;

    Optional: Change the below to MANUAL

    selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID;

    What alternative solutions did you explore? (Optional)

  5. Julesssss commented on Nov 5, 2024

    @Julesssss
    Contributor

    Hey @Nodebrute, ah nice spot, It does seem likey they are inverted. Are you able to raise a PR now?

  6. Nodebrute commented on Nov 5, 2024

    @Nodebrute
    Contributor

    @Julesssss On it.

  7. 26 remaining items

  8. changed the title [-][HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/-] [+][HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/+] on Nov 7, 2024
  9. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Nodebrute requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    @Julesssss @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Nov 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @Nodebrute paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1853831016472532052/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    @Julesssss, @mallenexpensify, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. mallenexpensify commented on Nov 18, 2024

    @mallenexpensify
    Contributor

    @Nodebrute apologies for the delay, can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021853831016472532052

  14. Nodebrute commented on Nov 19, 2024

    @Nodebrute
    Contributor

    @mallenexpensify accepted the offer, thank you.

  15. mallenexpensify commented on Nov 19, 2024

    @mallenexpensify
    Contributor

    Contributor: @Nodebrute paid $250 via Upwork

    No need for regression test case.

    Thx @Nodebrute !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions