You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens #52045
Version Number: 9.0.57-7 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):yonghongkok2+22skdpsdkok@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Sign up as a new Gmail user
Complete onboarding
Create a new workspace
Go to workspace settings > More features
Enable Workflows
Go to Workflows
Click Connect bank account
Click Connect online with Plaid
Enter magic code
Expected Result:
After entering magic code from Connect online with Plaid, Plaid page will open
Actual Result:
After entering magic code from Connect online with Plaid, "Manually add bank account" page opens
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6655471_1730812610903.bandicam_2024-11-05_21-10-35-451.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/-][+][HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/+]on Nov 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Julesssss@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Nov 5, 2024
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 5, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Nov 5, 2024
Edited by proposal-police: This proposal was edited at 2024-11-05 15:00:09 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
After entering magic code from Connect online with Plaid, manual set up opens
What is the root cause of that problem?
Here we set the subset to
MANUALThat is why after verification we navigate to manual pageApp/src/pages/ReimbursementAccount/BankAccountStep.tsx
Line 184 in b914945
I can see that this is also wrong the below code should be
MANUALApp/src/pages/ReimbursementAccount/BankAccountStep.tsx
Line 201 in b914945
What changes do you think we should make in order to solve the problem?
Change this to
CONST.BANK_ACCOUNT.SETUP_TYPE.PLAIDApp/src/pages/ReimbursementAccount/BankAccountStep.tsx
Line 184 in b914945
Optional: Change the below to
MANUALApp/src/pages/ReimbursementAccount/BankAccountStep.tsx
Line 201 in b914945
What alternative solutions did you explore? (Optional)
Julesssss commentedon Nov 5, 2024
Hey @Nodebrute, ah nice spot, It does seem likey they are inverted. Are you able to raise a PR now?
Nodebrute commentedon Nov 5, 2024
@Julesssss On it.
26 remaining items
[-][HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/-][+][HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens[/+]melvin-bot commentedon Nov 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 7, 2024
@Julesssss @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Nov 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Nov 15, 2024
@Julesssss, @mallenexpensify, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 18, 2024
@Nodebrute apologies for the delay, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021853831016472532052
Nodebrute commentedon Nov 19, 2024
@mallenexpensify accepted the offer, thank you.
mallenexpensify commentedon Nov 19, 2024
Contributor: @Nodebrute paid $250 via Upwork
No need for regression test case.
Thx @Nodebrute !