You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Console Error on [react-native-gesture-handler] when view a video attachment in a report #52157
Version Number: 9.0.57-3 Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@hoangzinh Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs
Action Performed:
Go to any chat
Send a video attachment
Tap on video attachment in the report
Expected Result:
No console error
Actual Result:
Console error: [react-native-gesture-handler] Some of the callbacks in the gesture are worklets and some are not
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceScreen.Recording.2024-11-05.at.07.04.10.mov
In progressBarInteraction, we update a shared value progressWidth which runs in Reanimated context >> progressBarInteraction gets automatically "workletized" (runs in UI thread) then onBegin and onChange callbacks consequently. Only onFinalize does not because it contains plain JS logic.
So we have 2 workletized and 1 non-workletized callbacks within the same gesture callbacks chain, causing react-native-gesture-handlerthrowing the error.
What changes do you think we should make in order to solve the problem?
Explicitly mark onFinalize callback as worklet by adding 'worklet'; directive at the beginning.
this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
MelvinBot commentedon Nov 6, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
mkzie2 commentedon Nov 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Console Error on [react-native-gesture-handler] when view a video attachment in a report
What is the root cause of that problem?
The issue arises from this gesture callback:
App/src/components/VideoPlayer/VideoPlayerControls/ProgressBar/index.tsx
Lines 47 to 63 in 5a2602c
In
progressBarInteraction, we update a shared valueprogressWidthwhich runs in Reanimated context >>progressBarInteractiongets automatically "workletized" (runs in UI thread) thenonBeginandonChangecallbacks consequently. OnlyonFinalizedoes not because it contains plain JS logic.So we have 2 workletized and 1 non-workletized callbacks within the same gesture callbacks chain, causing
react-native-gesture-handlerthrowing the error.What changes do you think we should make in order to solve the problem?
Explicitly mark
onFinalizecallback asworkletby adding'worklet';directive at the beginning.melvin-bot commentedon Nov 12, 2024
Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Nov 14, 2024
6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mkzie2 commentedon Nov 15, 2024
@m-natarajan This has not been assigned any one to take care of.
hoangzinh commentedon Nov 15, 2024
@mkzie2 do you still reproduce this console error on latest main branch?
mkzie2 commentedon Nov 15, 2024
@hoangzinh No longer after #51783. We can close this.
hoangzinh commentedon Nov 15, 2024
Thanks for confirmation @mkzie2
cc @m-natarajan
melvin-bot commentedon Nov 18, 2024
10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Nov 20, 2024
this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Nov 20, 2024
12 days overdue. Walking. Toward. The. Light...
hoangzinh commentedon Nov 20, 2024
Ping on Slack https://expensify.slack.com/archives/C049HHMV9SM/p1732096442605479?thread_ts=1730765319.227739&cid=C049HHMV9SM
melvin-bot commentedon Nov 25, 2024
This issue has not been updated in over 14 days. eroding to Weekly issue.
melvin-bot commentedon Dec 19, 2024
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mountiny commentedon Dec 19, 2024
No longer repro