You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-20] [$250] Track expense - Track expense options are still present in report header after it is submitted #52240
Version Number: 9.0.59-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers):applausetester+zm50@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Launch ND or hybrid app.
Go to self DM.
Track a manual expense.
Go to Search.
Tap on the track expense in Step 3.
Open report header.
Tap Categorize it.
Select a workspace, category, enter merchant and tap Submit.
Reopen the submitted expense in Step 8 in Search.
Note that header subtitle is updated to the workspace expense report.
Tap on the report header.
Expected Result:
Track expense options will no longer appear in report header when the report is opened in Search after it is submitted to workspace.
Actual Result:
Track expense options still appear in report header when the report is opened in Search after it is submitted to workspace.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/-][+][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/+]on Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@jliexpensify@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/-][+][HOLD for payment 2024-11-20] [$250] Track expense - Track expense options are still present in report header after it is submitted[/+]on Nov 15, 2024
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I don’t think there's a PR responsible for this, as it seems to be a missing case from when the new feature was implemented. The original author might not have been aware of the change, but I've provided a reason in the implementation PR https://github.com/Expensify/App/pull/37282/files#r1846901471
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A
Activity
melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 8, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 8, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Nov 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854881368705526819
25 remaining items
melvin-bot commentedon Nov 11, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 11, 2024
@suneox @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/-][+][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/+]melvin-bot commentedon Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 13, 2024
@suneox @jliexpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-20] [HOLD for payment 2024-11-18] [$250] Track expense - Track expense options are still present in report header after it is submitted[/-][+][HOLD for payment 2024-11-20] [$250] Track expense - Track expense options are still present in report header after it is submitted[/+]suneox commentedon Nov 18, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I don’t think there's a PR responsible for this, as it seems to be a missing case from when the new feature was implemented. The original author might not have been aware of the change, but I've provided a reason in the implementation PR https://github.com/Expensify/App/pull/37282/files#r1846901471
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A
jliexpensify commentedon Nov 20, 2024
Payment Summary
Upwork job
jliexpensify commentedon Nov 21, 2024
Paid and job closed!