Skip to content

[HOLD for payment 2024-12-03] [$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink #52258

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: NA
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): biruknew45+2025@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create workspace
  3. Go to the #admin room (if you couldn't find it in LHN go to account setting> workspace > click on the three dots then click on #admin room)
  4. Click on the header > share code then see the shape of the profile picture
  5. Go to workspace editor > profile > share code > click on #admins hyper link
  6. click on the header > share code and see the shape of the profile picture.

Expected Result:

The profile picture should consistently appear as a circle

Actual Result:

When navigating to the admin room share code through the #admin hyperlink, the profile picture appears as a rectangle

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6658801_1731068758423.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854973788673857466
  • Upwork Job ID: 1854973788673857466
  • Last Price Increase: 2024-11-08
  • Automatic offers:
    • ikevin127 | Reviewer | 104896217
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 8, 2024
  2. melvin-bot commented on Nov 8, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. joekaufmanexpensify commented on Nov 8, 2024

    @joekaufmanexpensify
    Contributor

    Reproduced.

    2024-11-08_14-45-28.mp4
  4. changed the title [-]Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-] [+][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+] on Nov 8, 2024
  5. melvin-bot commented on Nov 8, 2024

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 8, 2024
  7. melvin-bot commented on Nov 8, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  8. joekaufmanexpensify commented on Nov 8, 2024

    @joekaufmanexpensify
    Contributor

    Seems like a pretty minor bug, so bumping down.

  9. changed the title [-][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-] [+][$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+] on Nov 8, 2024
  10. melvin-bot commented on Nov 8, 2024

    @melvin-bot

    Upwork job price has been updated to $125

  11. 29 remaining items

  12. melvin-bot commented on Nov 26, 2024

    @melvin-bot

    @ikevin127 @joekaufmanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. ikevin127 commented on Nov 26, 2024

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/45374/files#r1859324788.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    1. Navigate to Settings > Workspaces, open a workspace profile, and click the Share button.
    2. Click on the #admin hyperlink, then click the Header of the opened report and select the Share button.
    3. Verify that the profile picture QR Code appears in a circular shape.

    Do we agree 👍 or 👎.

  14. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    Great. I will handle next steps!

  15. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    @Shahidullah-Muffakir offer sent for $125!

  16. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Dec 3, 2024
  17. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    This is a pretty niche bug, I don't think we need a regression test everytime here.

  18. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    All set to pay:

  19. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    @ikevin127 $125 sent and contract ended

  20. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    @Shahidullah-Muffakir $125 sent and contract ended

  21. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  22. joekaufmanexpensify commented on Dec 3, 2024

    @joekaufmanexpensify
    Contributor

    All set, thanks everyone!

  23. moved this from Hold for Payment to Done in #expensify-bugson Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions