You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-03] [$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink #52258
Version Number: 9.0.59-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: NA If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):biruknew45+2025@gmail.com Issue reported by: Applause - Internal Team
changed the title [-]Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-][+][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+]on Nov 8, 2024
changed the title [-][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-][+][$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+]on Nov 8, 2024
@ikevin127@joekaufmanexpensify@ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Navigate to Settings > Workspaces, open a workspace profile, and click the Share button.
Click on the #admin hyperlink, then click the Header of the opened report and select the Share button.
Verify that the profile picture QR Code appears in a circular shape.
Activity
melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.joekaufmanexpensify commentedon Nov 8, 2024
Reproduced.
2024-11-08_14-45-28.mp4
[-]Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-][+][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+]melvin-bot commentedon Nov 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854973788673857466
melvin-bot commentedon Nov 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)joekaufmanexpensify commentedon Nov 8, 2024
Seems like a pretty minor bug, so bumping down.
[-][$250] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/-][+][$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink[/+]melvin-bot commentedon Nov 8, 2024
Upwork job price has been updated to $125
29 remaining items
melvin-bot commentedon Nov 26, 2024
@ikevin127 @joekaufmanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ikevin127 commentedon Nov 26, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/45374/files#r1859324788.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Do we agree 👍 or 👎.
joekaufmanexpensify commentedon Dec 2, 2024
Great. I will handle next steps!
joekaufmanexpensify commentedon Dec 2, 2024
@Shahidullah-Muffakir offer sent for $125!
joekaufmanexpensify commentedon Dec 3, 2024
This is a pretty niche bug, I don't think we need a regression test everytime here.
joekaufmanexpensify commentedon Dec 3, 2024
All set to pay:
joekaufmanexpensify commentedon Dec 3, 2024
@ikevin127 $125 sent and contract ended
joekaufmanexpensify commentedon Dec 3, 2024
@Shahidullah-Muffakir $125 sent and contract ended
joekaufmanexpensify commentedon Dec 3, 2024
Upwork job closed.
joekaufmanexpensify commentedon Dec 3, 2024
All set, thanks everyone!