You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-05] [$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards #52316
Someone can issue multiple physical expensify cards on behalf of a domain without verifying they are actually the owner of the account. This relates to an internal security issue.
Why this is important to solve
This is a security vulnerability that can be taken advantage of if an account is compromised.
Solution
Collect a magic code when requesting a physical Expensify card. In a little more detail:
It should have a new parameter called validateCode that is passed to the server
In order to do this, anything calling updatePersonalDetailsAndShipExpensifyCards needs a new step to gather a magic code from the user with the ValidateCodeActionModal component from this PR.
changed the title [-]Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/-][+][$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/+]on Nov 11, 2024
Update function handleFinishStep to open magic code modal then onSubmit of magic code modal call API get validateCode and send it to updatePersonalDetailsAndShipExpensifyCards API
changed the title [-][$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/-][+][HOLD for payment 2024-12-05] [$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/+]on Nov 28, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rushatgabhane@JmillsExpensify@rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Not a bug. New feature. So we should add a regression test
Prerequisites:
Workspace is connected with a bank account.
Workspace has a member invited.
Workspace has enabled Expensify card.
Admin has issued a physical card for employee.
1. Employee clicks to the "Add shipping detail" button
2. Finish this flow
3. Verify that: At the end of this flow, require magic code modal is displayed
Activity
melvin-bot commentedon Nov 11, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/-][+][$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/+]melvin-bot commentedon Nov 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021856002885580948055
melvin-bot commentedon Nov 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)nkdengineer commentedon Nov 11, 2024
Edited by proposal-police: This proposal was edited at 2024-11-11 16:15:02 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Require magic code validation for SetPersonalDetailsAndShipExpensifyCards
What is the root cause of that problem?
This is a new feature request
What changes do you think we should make in order to solve the problem?
ValidateCodeActionModaltoMissingPersonalDetailsContentcomponentApp/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx
Line 34 in 26bae60
Update function
handleFinishStepto open magic code modal thenonSubmitof magic code modal call API getvalidateCodeand send it toupdatePersonalDetailsAndShipExpensifyCardsAPIAdd
validateCodeto this parametersApp/src/libs/actions/PersonalDetails.ts
Line 469 in 26bae60
What alternative solutions did you explore? (Optional)
rushatgabhane commentedon Nov 12, 2024
This is straight forward implementation issue. let's hire @nkdengineer
🎀 👀 🎀
melvin-bot commentedon Nov 12, 2024
Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
MarioExpensify commentedon Nov 12, 2024
Moving forward with @nkdengineer, thank you @rushatgabhane!!
8 remaining items
[-][$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/-][+][HOLD for payment 2024-12-05] [$250] Require magic code validation for SetPersonalDetailsAndShipExpensifyCards[/+]melvin-bot commentedon Nov 28, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 28, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 28, 2024
@rushatgabhane @JmillsExpensify @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rushatgabhane commentedon Dec 2, 2024
Checklist
Not a bug. New feature. So we should add a regression test
JmillsExpensify commentedon Dec 9, 2024
Payment summary:
JmillsExpensify commentedon Dec 9, 2024
@rushatgabhane please submit via New Expensify. Contributor paid via Upwork and regression test created.
garrettmknight commentedon Dec 12, 2024
$250 approved for @rushatgabhane