Skip to content

[Payment 2025-01-15] [$250] Category - Description hint field shows previous data after reenabling "Require description" #52399

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+zm27@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Rules are enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories.
  3. Click on any category.
  4. Enable "Require description".
  5. Click Description hint.
  6. Enter anything and save it.
  7. Disable "Require description".
  8. Enable "Require description".
  9. Note that Description hint field is empty.
  10. Dismiss the RHP.
  11. Click on the same category.

Expected Result:

Description hint field will remain empty.

Actual Result:

Description hint field shows the previous data after reopening category settings.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6662259_1731402885400.20241112_171047.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021858724639436105772
  • Upwork Job ID: 1858724639436105772
  • Last Price Increase: 2024-11-26
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 12, 2024
  2. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 18, 2024

    @melvin-bot

    @strepanier03 Eep! 4 days overdue now. Issues have feelings too...

  4. strepanier03 commented on Nov 19, 2024

    @strepanier03
    Contributor

    I was able to reproduce this and have tied it to a project. Setting external now.

  5. changed the title [-]Category - Description hint field shows previous data after reenabling "Require description"[/-] [+][$250] Category - Description hint field shows previous data after reenabling "Require description"[/+] on Nov 19, 2024
  6. melvin-bot commented on Nov 19, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 19, 2024
  8. 44 remaining items

  9. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 14, 2025
  10. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1858724639436105772/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. parasharrajat commented on Jan 15, 2025

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/48171/files#r1916322984

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not needed.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open the Expensify app.
    2. Navigate to Workspace Settings > Categories.
    3. Click on any category.
    4. Enable "Require description".
    5. Click on Description hint.
    6. Enter any value and save it.
    7. Disable "Require description".
    8. Re-enable "Require description".
    9. Note that the Description hint field is empty.
    10. Dismiss the RHP (Right Hand Panel).
    11. Click on the same category again.
    12. Verify that the Description hint field remains empty.

    Do we agree 👍 or 👎

  12. strepanier03 commented on Jan 16, 2025

    @strepanier03
    Contributor

    Payment Summary

    Status: 🟢 - READY FOR PAYMENT

  13. strepanier03 commented on Jan 16, 2025

    @strepanier03
    Contributor

    @huult I had to make a new job in Upwork because the previous one expired, I rehired you for it and will check to pay it out again later today.

    @parasharrajat - The payment summary is here and you're welcome to request payment now.

    Thank you both!

  14. changed the title [-][HOLD for payment 2025-01-15] [$250] Category - Description hint field shows previous data after reenabling "Require description"[/-] [+][Payment 2025-01-15] [$250] Category - Description hint field shows previous data after reenabling "Require description"[/+] on Jan 16, 2025
  15. huult commented on Jan 16, 2025

    @huult
    Contributor

    @strepanier03 thank you! accepted your offer

  16. strepanier03 commented on Jan 17, 2025

    @strepanier03
    Contributor

    I paid the contract for @huult and am going to close this out now since the ND request is all that's left.

  17. moved this from Hold for Payment to Done in #expensify-bugson Jan 17, 2025
  18. parasharrajat commented on Jan 19, 2025

    @parasharrajat
    Member

    Payment requested as per #52399 (comment)

  19. JmillsExpensify commented on Jan 22, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions