Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation (hyperlinked to channel name): ts_external_expensify_expense
Action Performed:
- Create a workspace
- Invite Submitter + Approver A
- Enable Workflows > Approval + Delay Submission
- Set Approver A as approver
- As Submitter, create expense in WS chat + submit
- Tag the approver in the workspace chat and invite them
- As Approver A, navigate to Submitter's WS chat + click the three dot menu on the expense
Expected Result:
Since this is a one expense report, you should see Hold in the three dot menu for the report
Actual Result:
The Hold action is not available in the menu until you open the expense and go back
Workaround:
You don't see Hold until you access the expense/report and back out into the WS chat again.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
HoldMenu2024-12-12_15-59-35.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021857521697236720139
- Upwork Job ID: 1857521697236720139
- Last Price Increase: 2024-11-22
Issue Owner
Current Issue Owner: @neil-marcelliniMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Nov 12, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.CortneyOfstad commentedon Nov 15, 2024
I was able to recreate this under my expensifail.com account, so getting some eyes on this!
[-]Hold doesn't show in three dot menu until report is opened[/-][+][$250] Hold doesn't show in three dot menu until report is opened[/+]melvin-bot commentedon Nov 15, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021857521697236720139
melvin-bot commentedon Nov 15, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)143 remaining items
[-][CRITICAL] Hold doesn't show in three dot menu until report is opened[/-][+][HIGH] Hold doesn't show in three dot menu until report is opened[/+]CortneyOfstad commentedon May 20, 2025
Hey @iwiznia — checking to see if there is an update? Thanks!
iwiznia commentedon May 23, 2025
Alright, I looked into this again. I think the main issue here is that we are never loading from the server the reportActions of the expense report that we are getting from onyx here, so it does not find it here, so
moneyRequestActionhere is undefined and we pass it here so in this shouldShow method we return false.I don't think we can load all reportActions of all expense reports in the workspace chat, so unsure about what the solution should be 🤔
iwiznia commentedon May 23, 2025
The only thing I can think of is to move all the logic to the backend and return something like
canHold: bool, canUnhold: booldirectly from the server as part of the expense report's data OR as part of the reportActions's data.iwiznia commentedon May 23, 2025
Or maybe even return a
allowedActionsproperty with a list of actions that are allowed and basically replace all theshouldShowmethods ofContextMenuActions.tsxwith the data coming from the server.It of course is more work, but:
iwiznia commentedon May 23, 2025
Conversation about the proposal above here https://expensify.slack.com/archives/C03TQ48KC/p1748001911447839
CortneyOfstad commentedon May 23, 2025
Thanks @iwiznia!
CortneyOfstad commentedon May 30, 2025
Update: PR is actively moving — found some conflicts and Viktoryia found a bug during the retesting. Most recent comment is here with Vik asking @iwiznia for a review 👍
CortneyOfstad commentedon Jun 3, 2025
PR has been merged, but has not deployed to staging yet.
@iwiznia — just a heads up that I am heading OoO this afternoon (6/3) to Monday (6/9) so if any action is needed from a BZ perspective, please reapply the label. Otherwise I will get it addressed as soon as I am back. Thanks!
CortneyOfstad commentedon Jun 9, 2025
I'm back! PR was deployed to staging 4 days ago, so will keep an eye out for when it is in production 👍
CortneyOfstad commentedon Jun 13, 2025
PR was merged and issue is resolved (unable to recreate) — closing this out!