You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Hold for payment 2024-12-25][$250] Timezone is not updated to the messages sent #52975
Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@neil-marcellini Slack conversation (hyperlinked to channel name): expensify - bugs
Action Performed:
Set your timezone automatically
Send a message and note the time is displayed properly
Travel to a new timezone
Verify your timezone shows that it has updated in Settings > Profile
Send another message
Expected Result:
The created time is shown in the user's updated current timezone
Actual Result:
The created time is shown in the user's previous timezone
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://app.screencast.com/LHXPoXQVOgFgJ
[View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22)
Upwork Automation - Do Not Edit
I can help with this one on the internal engineering side. First we need to figure out how to reproduce it. Is there a way we can mess with the networks settings to make the computer think it has changed timezones? Probably. @getusha could you please try to reproduce that way?
It compares the user saved timezone with the current timezone of the device. If it's different, then it updates the timezone. However, it doesn't work correctly. In updateAutomaticTimezone, we already optimistically update the timezone, but it's never applied.
We already update the timezone optimistically inside updateAutomaticTimezone. But if we still need to update the timezone object immediately, we need to clone the timezone object here.
Payment summary: @bernhardoj $250 please request in ND @getusha $250 please request in ND - as the C+ could you please complete the checklist? Sharing the template below 👇
Checklist, click to unfurl
# BugZero Checklist:
- [ ] **[Contributor]** Classify the bug:
<details>
<summary>Bug classification</summary>
<!-- Please keep the "1a." text in tact on all of the options below so that the results can be easily parsed by a script. Each of the "Other" options should be last on the list which is why they have a "z" in the selector (eg. "1z."). This allows the list to grow if someone desires to add more options down the road. -->
Source of bug:
- [ ] 1a. Result of the original design (eg. a case wasn't considered)
- [ ] 1b. Mistake during implementation
- [ ] 1c. Backend bug
- [ ] 1z. Other:
Where bug was reported:
- [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- [ ] 2b. Reported on staging (eg. found during regression or PR testing)
- [ ] 2d. Reported on a PR
- [ ] 2z. Other:
Who reported the bug:
- [ ] 3a. Expensify user
- [ ] 3b. Expensify employee
- [ ] 3c. Contributor
- [ ] 3d. QA
- [ ] 3z. Other:
</details>
- [ ] **[Contributor]** The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
- [ ] **[Contributor]** If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in [#expensify-open-source](https://app.slack.com/client/E047TPA624F/C01GTK53T8Q) has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
- [ ] **[Contributor]** If it was decided to create a regression test for the bug, please propose the [regression test](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md) steps using the template below to ensure the same bug will not reach production again.
<details>
<summary>Regression Test Proposal Template</summary>
<!-- AFTER FILLING THIS OUT, be sure to remove the <details> and <summary> tags from this part of the checklist!!!!! -->
- [ ] **[BugZero Assignee]** Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
## Regression Test Proposal
### Precondition:
<!-- List the setup instructions necessary to perform the test -->
-
### Test:
<!-- List the steps that QA should perform -->
1.
Do we agree 👍 or 👎
<!-- AFTER FILLING THIS OUT, be sure to remove the <details> tags!!!!! -->
</details>
changed the title [-][$250] Timezone is not updated to the messages sent[/-][+][Hold for payment 2024-12-25][$250] Timezone is not updated to the messages sent[/+]on Jan 24, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Nov 22, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Nov 22, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
[-]Timezone is not updated to the messages sent[/-][+][$250] Timezone is not updated to the messages sent[/+]melvin-bot commentedon Nov 22, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021860030469423904950
melvin-bot commentedon Nov 22, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)neil-marcellini commentedon Nov 22, 2024
I can help with this one on the internal engineering side. First we need to figure out how to reproduce it. Is there a way we can mess with the networks settings to make the computer think it has changed timezones? Probably. @getusha could you please try to reproduce that way?
bernhardoj commentedon Nov 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The timezone is not updated.
What is the root cause of that problem?
I can repro this with the following steps:
On the step 3, this logic will be executed.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 154 to 171 in 3ebe852
It compares the user saved timezone with the current timezone of the device. If it's different, then it updates the timezone. However, it doesn't work correctly. In
updateAutomaticTimezone, we already optimistically update the timezone, but it's never applied.App/src/libs/actions/PersonalDetails.ts
Lines 252 to 261 in 3ebe852
It's because onyx detected that there is nothing to change. Why? It's because before we update the onyx, we mutate the object of the timezone.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 167 to 171 in 3ebe852
We also have a logic to update the timezone when adding an action, but since we mutate the timezone object, the onyx storage is never updated.
App/src/libs/actions/Report.ts
Lines 649 to 659 in 3ebe852
What changes do you think we should make in order to solve the problem?
Don't mutate the timezone object here.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 167 to 171 in 3ebe852
We already update the timezone optimistically inside
updateAutomaticTimezone. But if we still need to update the timezone object immediately, we need to clone the timezone object here.App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Line 161 in 3ebe852
45 remaining items
melvin-bot commentedon Jan 24, 2025
@sonialiap, @neil-marcellini, @bernhardoj, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
sonialiap commentedon Jan 24, 2025
🙈 automation didn't run, making payments now
sonialiap commentedon Jan 24, 2025
Payment summary:
@bernhardoj $250 please request in ND
@getusha $250 please request in ND - as the C+ could you please complete the checklist? Sharing the template below 👇
Checklist, click to unfurl
[-][$250] Timezone is not updated to the messages sent[/-][+][Hold for payment 2024-12-25][$250] Timezone is not updated to the messages sent[/+]bernhardoj commentedon Jan 24, 2025
Requested in ND.
getusha commentedon Jan 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/28307/files#r1930871527
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/465177
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Jan 28, 2025
@sonialiap, @neil-marcellini, @bernhardoj, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
JmillsExpensify commentedon Jan 29, 2025
$250 approved for @bernhardoj
garrettmknight commentedon Jan 29, 2025
$250 approved for @getusha