You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-10] [$500] Android - Chat - Code block alignment is too high in Android #53458
Version Number: 9.0.70-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team
Action Performed:
Launch app in both mweb and android
Open a chat
Enter Testing "hello" testing
Send the message
Expected Result:
Code blocks must display consistently in both mweb and android.
Actual Result:
In mWeb, code block alignment is correct, while in Android, code block alignment is too high.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
I think that the quotation mark alignment is the same for both platforms, while the code snippet alignment is different. In Android, the code snippet looks much higher and closer to the text above than in mWeb. @Expensify/design could I get a gut check on that?
Pulling out screenshots from the video, since it took me a while to see the different while watching the video.
changed the title [-]Android - Chat - Double quotes shown in middle in android[/-][+]Android - Chat - Code block alignment is too high in Android[/+]on Dec 4, 2024
changed the title [-]Android - Chat - Code block alignment is too high in Android[/-][+][$250] Android - Chat - Code block alignment is too high in Android[/+]on Dec 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@sakluger@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: This was a upsteam bug
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A this bug exits upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
N/A
Test:
For Android/iOS
Go to any chat.
Send a message that contains inline code blocks and emojis e.g. Lorem ipsum dolor 🚀 sit amet, cons``ectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 🚀
Assert a different font and background are being applied to the code blocks and they are properly aligned with the normal text.
Go to Settings and switch the Theme.
Go to the chat again and assert it's using the corresponding styles from that theme.
For the other Platforms
Go to any chat.
Send a message that contains inline code blocks and emojis e.g. Lorem ipsum dolor 🚀 sit amet, cons``ectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 🚀
Assert the same code block stylings as we have today are being used and they are properly aligned with the normal text.
Go to Settings and switch the Theme.
Go to the chat again and assert it's using the corresponding styles from that Theme.
Hey @allgandalf and @grgia - I saw this comment mention that this issue's PR caused a follow-up issue. Would we consider that a regression, or is that follow-up work out of scope of this issue?
Activity
melvin-bot commentedon Dec 3, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.sakluger commentedon Dec 4, 2024
I think that the quotation mark alignment is the same for both platforms, while the code snippet alignment is different. In Android, the code snippet looks much higher and closer to the text above than in mWeb. @Expensify/design could I get a gut check on that?
Pulling out screenshots from the video, since it took me a while to see the different while watching the video.
Here's mWeb:
Here's Android:
dubielzyk-expensify commentedon Dec 4, 2024
Agree that the code snipped looks a tad high, @sakluger .
Also, could we see how it looks when you insert more text like this:

Cause that'll give us a better idea of what's actually misaligned here
sakluger commentedon Dec 4, 2024
Good suggestion! Here's that same longer string in Android - it's pretty clear that the code block is aligned super high:
[-]Android - Chat - Double quotes shown in middle in android[/-][+]Android - Chat - Code block alignment is too high in Android[/+][-]Android - Chat - Code block alignment is too high in Android[/-][+][$250] Android - Chat - Code block alignment is too high in Android[/+]melvin-bot commentedon Dec 4, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021864441841607834076
melvin-bot commentedon Dec 4, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)sakluger commentedon Dec 4, 2024
I updated the GH issue title and the actual/expected behavior in the OP.
120 remaining items
melvin-bot commentedon Mar 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 3, 2025
@allgandalf @sakluger @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 4, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
grgia commentedon Mar 5, 2025
melvin what
allgandalf commentedon Mar 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A this bug exits upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
For Android/iOS
dolor 🚀sit amet, cons``ecteturadipiscing elit, sed do eiusmod tempor incididuntut labore et doloremagnaaliqua. 🚀For the other Platforms
dolor 🚀sit amet, cons``ecteturadipiscing elit, sed do eiusmod tempor incididuntut labore et doloremagnaaliqua. 🚀Do we agree 👍 or 👎
melvin-bot commentedon Mar 10, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
sakluger commentedon Mar 10, 2025
Hey @allgandalf and @grgia - I saw this comment mention that this issue's PR caused a follow-up issue. Would we consider that a regression, or is that follow-up work out of scope of this issue?
sakluger commentedon Mar 10, 2025
I'm going to send the contract via Upwork now (https://www.upwork.com/nx/wm/offer/106461905). If this issue caused a regression, we can always adjust the payout.
allgandalf commentedon Mar 10, 2025
Thanks for the offer @sakluger , we knew about the bug reported already during our original PR implementation here:
And we decided to proceed and follow up in issue:
inline codeblocks on native devices #57556So no, not a regression, c.c. @shawnborton and @fabioh8010 to confirm 🙇
sakluger commentedon Mar 10, 2025
Thanks @allgandalf! I trust you.
Summarizing payment on this issue:
Contributor: @fabioh8010 - no payment required
Contributor+: @allgandalf $500, paid via Upwork