Skip to content

[Due for payment 2025-03-10] [$500] Android - Chat - Code block alignment is too high in Android #53458

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.70-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app in both mweb and android
  2. Open a chat
  3. Enter Testing "hello" testing
  4. Send the message

Expected Result:

Code blocks must display consistently in both mweb and android.

Actual Result:

In mWeb, code block alignment is correct, while in Android, code block alignment is too high.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864441841607834076
  • Upwork Job ID: 1864441841607834076
  • Last Price Increase: 2025-03-04
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 3, 2024
  2. melvin-bot commented on Dec 3, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. sakluger commented on Dec 4, 2024

    @sakluger
    Contributor

    I think that the quotation mark alignment is the same for both platforms, while the code snippet alignment is different. In Android, the code snippet looks much higher and closer to the text above than in mWeb. @Expensify/design could I get a gut check on that?

    Pulling out screenshots from the video, since it took me a while to see the different while watching the video.

    Here's mWeb:

    image

    Here's Android:

    image
  4. dubielzyk-expensify commented on Dec 4, 2024

    @dubielzyk-expensify
    Contributor

    Agree that the code snipped looks a tad high, @sakluger .

    Also, could we see how it looks when you insert more text like this:
    CleanShot 2024-12-05 at 08 22 32@2x

    Cause that'll give us a better idea of what's actually misaligned here

  5. sakluger commented on Dec 4, 2024

    @sakluger
    Contributor

    Good suggestion! Here's that same longer string in Android - it's pretty clear that the code block is aligned super high:

    image
  6. changed the title [-]Android - Chat - Double quotes shown in middle in android[/-] [+]Android - Chat - Code block alignment is too high in Android[/+] on Dec 4, 2024
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 4, 2024
  8. changed the title [-]Android - Chat - Code block alignment is too high in Android[/-] [+][$250] Android - Chat - Code block alignment is too high in Android[/+] on Dec 4, 2024
  9. melvin-bot commented on Dec 4, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2024
  11. melvin-bot commented on Dec 4, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  12. sakluger commented on Dec 4, 2024

    @sakluger
    Contributor

    I updated the GH issue title and the actual/expected behavior in the OP.

  13. 120 remaining items

  14. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allgandalf requires payment (Needs manual offer from BZ)
  16. melvin-bot commented on Mar 3, 2025

    @melvin-bot

    @allgandalf @sakluger @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. melvin-bot commented on Mar 4, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  18. grgia commented on Mar 5, 2025

    @grgia
    Contributor

    melvin what

  19. allgandalf commented on Mar 9, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: This was a upsteam bug

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A this bug exits upstream

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • N/A

    Test:

    For Android/iOS

    1. Go to any chat.
    2. Send a message that contains inline code blocks and emojis e.g. Lorem ipsum dolor 🚀 sit amet, cons``ectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 🚀
    3. Assert a different font and background are being applied to the code blocks and they are properly aligned with the normal text.
    4. Go to Settings and switch the Theme.
    5. Go to the chat again and assert it's using the corresponding styles from that theme.

    For the other Platforms

    1. Go to any chat.
    2. Send a message that contains inline code blocks and emojis e.g. Lorem ipsum dolor 🚀 sit amet, cons``ectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 🚀
    3. Assert the same code block stylings as we have today are being used and they are properly aligned with the normal text.
    4. Go to Settings and switch the Theme.
    5. Go to the chat again and assert it's using the corresponding styles from that Theme.

    Do we agree 👍 or 👎

  20. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@sakluger)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1864441841607834076/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  21. sakluger commented on Mar 10, 2025

    @sakluger
    Contributor

    Hey @allgandalf and @grgia - I saw this comment mention that this issue's PR caused a follow-up issue. Would we consider that a regression, or is that follow-up work out of scope of this issue?

  22. sakluger commented on Mar 10, 2025

    @sakluger
    Contributor

    I'm going to send the contract via Upwork now (https://www.upwork.com/nx/wm/offer/106461905). If this issue caused a regression, we can always adjust the payout.

  23. allgandalf commented on Mar 10, 2025

    @allgandalf
    Contributor

    Thanks for the offer @sakluger , we knew about the bug reported already during our original PR implementation here:

    And we decided to proceed and follow up in issue:

    So no, not a regression, c.c. @shawnborton and @fabioh8010 to confirm 🙇

  24. sakluger commented on Mar 10, 2025

    @sakluger
    Contributor

    Thanks @allgandalf! I trust you.

    Summarizing payment on this issue:

    Contributor: @fabioh8010 - no payment required
    Contributor+: @allgandalf $500, paid via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions