Skip to content

[HOLD for payment 2024-12-16] Card assignment cleanup, multiple members down to one  #53469

Closed

Description

@joekaufmanexpensify

Follow up of #52820, discussed here in Slack. If a workspace only has one member, we're correctly automatically selecting the one member (rather than forcing you to select them). However, if it previously had multiple members and then goes down to one, we force you to select that member when assigning a card. We shouldn't do this for custom or direct feeds.

2024-12-02_13-18-09.mp4
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. melvin-bot commented on Dec 3, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  2. moved this to Bugs and Follow Up Issues in #expensify-bugson Dec 3, 2024
  3. VickyStash commented on Dec 4, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  4. VickyStash commented on Dec 4, 2024

    @VickyStash
    Contributor

    The PR is ready for the review!

  5. 1 remaining item

  6. changed the title [-]Card assignment cleanup, multiple members down to one [/-] [+][HOLD for payment 2024-12-16] Card assignment cleanup, multiple members down to one [/+] on Dec 9, 2024
  7. melvin-bot commented on Dec 9, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Dec 9, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-16. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Dec 9, 2024

    @melvin-bot

    @DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Dec 10, 2024
  11. melvin-bot commented on Dec 16, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. DylanDylann commented on Dec 16, 2024

    @DylanDylann
    Contributor

    NO need payment, no need checklist

  13. DylanDylann commented on Dec 16, 2024

    @DylanDylann
    Contributor

    The checklist is covered here

  14. moved this from Hold for Payment to Done in #expensify-bugson Dec 16, 2024
  15. QichenZhu commented on Aug 24, 2026

    @QichenZhu
    Contributor

    This is related to issue #97692, which was fixed via PR #97925. See details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions