You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] iOS - Keyboard opens in front of the hold banner #53572
Version Number: 9.0.71-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#49971 Email or phone of affected tester (no customers):nathanmulugetatesting+2264@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Open hybrid app on a new account
Create a workspace
Submit expenses
Go into the transaction thread of one of the expenses
Tap on header > Hold
Expected Result:
The keyboard doesn't open while the banner is shown
Meanwhile, the input will be focused automatically if we are focusing on it before, so the composer is focused and the keyboard is opening.
As a result, the keyboard opens in front of the hold banner.
What changes do you think we should make in order to solve the problem?
When we open the popover, we should hide the keyboard. And after the popover is closed, we should focus on the composer if it is focused before (Optional). So the Popover component:
Should add a flag param such as shouldCloseKeyboardOnOpen and just call Keyboard.dismiss() if that param is true
Note: These two alternative solutions will work in all other modals, not only the hold modal. And, the feature "after the popover is closed, we should focus on the composer if it is focused before (Optional)" is handled like what I mentioned in the main solution.
changed the title [-][HOLD for payment 2025-01-21] [$250] iOS - Keyboard opens in front of the hold banner[/-][+][$250] iOS - Keyboard opens in front of the hold banner[/+]on Jan 14, 2025
@truph01 and @eVoloshchak are, very likely, due compensation because they hired/assigned.
The PR was created and reviewed so compensation is 100%
Contributor: @truph01 paid $250 via Upwork
Contributor+: @eVoloshchak due $250 via NewDot
Deets from this SO (also noticed there are two payment-related SOs, I'm going to combine those today
If a contributor has been hired for a job and we decide to close the job before it is successfully completed
50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.
100% due if contributor drafted a PR and requested a review.
100% due to C+ if they reviewed the PR.
One caveat here might be if the hired contributor wasn't working on their PR with urgency.
Activity
melvin-bot commentedon Dec 4, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.truph01 commentedon Dec 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/components/MoneyReportHeader.tsx
Lines 512 to 513 in d7859ea
App/src/components/MoneyRequestHeader.tsx
Lines 218 to 219 in d7859ea
Meanwhile, the input will be focused automatically if we are focusing on it before, so the composer is focused and the keyboard is opening.
As a result, the keyboard opens in front of the hold banner.
What changes do you think we should make in order to solve the problem?
Popovercomponent:App/src/components/ProcessMoneyRequestHoldMenu.tsx
Line 45 in d7859ea
can be updated to:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Alternative solution 1:
Alternative solution 2:
Keyboard.dismiss()in:App/src/components/Modal/BaseModal.tsx
Line 106 in 5180ef4
shouldCloseKeyboardOnOpenand just callKeyboard.dismiss()if that param istrueNote: These two alternative solutions will work in all other modals, not only the hold modal. And, the feature "after the popover is closed, we should focus on the composer if it is focused before (Optional)" is handled like what I mentioned in the main solution.
melvin-bot commentedon Dec 10, 2024
@anmurali Huh... This is 4 days overdue. Who can take care of this?
[-]iOS - Keyboard opens in front of the hold banner[/-][+][$250] iOS - Keyboard opens in front of the hold banner[/+]melvin-bot commentedon Dec 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021866934797160828341
melvin-bot commentedon Dec 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)33 remaining items
rlinoz commentedon Jan 14, 2025
Not awaiting payment, the solution was reverted
[-][HOLD for payment 2025-01-21] [$250] iOS - Keyboard opens in front of the hold banner[/-][+][$250] iOS - Keyboard opens in front of the hold banner[/+]truph01 commentedon Jan 23, 2025
I am unable to reproduce this issue anymore:
Screen.Recording.2025-01-23.at.17.31.08.mov
rlinoz commentedon Jan 27, 2025
Double checking #53572 (comment)
rlinoz commentedon Jan 27, 2025
Can't repro anymore either
anmurali commentedon Jan 29, 2025
Closing.
truph01 commentedon Jan 29, 2025
@anmurali Since both C+ and I spend efforts toward the PR, should we still be eligible for compensation here?
truph01 commentedon Jan 30, 2025
@rlinoz @anmurali Could you please help check my comment above once you have a chance? Thanks
mallenexpensify commentedon Jan 31, 2025
@truph01 and @eVoloshchak are, very likely, due compensation because they hired/assigned.
The PR was created and reviewed so compensation is 100%
Contributor: @truph01 paid $250 via Upwork
Contributor+: @eVoloshchak due $250 via NewDot
Deets from this SO (also noticed there are two payment-related SOs, I'm going to combine those today
If a contributor has been hired for a job and we decide to close the job before it is successfully completed
JmillsExpensify commentedon Mar 3, 2025
$250 approved for @eVoloshchak