Skip to content

[HOLD for payment 2025-01-02] [$50] Inconsistent display of measurement units #54226

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.76-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

  1. Try uploading an avatar with an image larger than 6 MB.
  2. Try adding a attachment with a file larger than 24 MB.
  3. Observe the error displayed.

Expected Result:

Consistent display of measurement units

Actual Result:

We are displaying inconsistently "6MB" and "24 MB".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
![bug 1](https://github.com/user-attachments/assets/d4276e6d-b494-4fa8-949d-36633f93a56a)

bug 2

Snip - (22) New Expensify - Google Chrome (2)

Snip - (22) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021869142033023958876
  • Upwork Job ID: 1869142033023958876
  • Last Price Increase: 2024-12-18
  • Automatic offers:
    • shubham1206agra | Contributor | 105392311
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 17, 2024
  2. melvin-bot commented on Dec 17, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dukenv0307 commented on Dec 17, 2024

    @dukenv0307
    Contributor

    @Christinadobrzyn I can help take this issue as C+ since I have the context on it

  4. shubham1206agra commented on Dec 17, 2024

    @shubham1206agra
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Inconsistent display of measurement units

    What is the root cause of that problem?

    In translation files

    sizeExceeded: 'Attachment size is larger than 24 MB limit',

    sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

    sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

    logSizeTooLarge: ({size}: LogSizeParams) => `Log size exceeds the limit of ${size} MB. Please use "Save log" to download the log file instead.`,

    The translation of size is inconsistent.

    What changes do you think we should make in order to solve the problem?

    Make the above translations consistent. @jamesdeanexpensify can chime in here for the translations

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA since it is a UI change

    What alternative solutions did you explore? (Optional)

    NA

  5. nyomanjyotisa commented on Dec 17, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Inconsistent display of measurement units

    What is the root cause of that problem?

    We are inconsistently create the translation copies

    sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

    sizeExceeded: 'Attachment size is larger than 24 MB limit',

    What changes do you think we should make in order to solve the problem?

    Add space before MB in the following copies, and its translation in .es file

    sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

    sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

  6. daledah commented on Dec 17, 2024

    @daledah
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-17 02:40:04 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    We are displaying inconsistently "6MB" and "24 MB".

    What is the root cause of that problem?

    We are not consistent when displaying measurement units

    sizeExceeded: 'Attachment size is larger than 24 MB limit',

    sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

    What changes do you think we should make in order to solve the problem?

    We can remove space before MB

    sizeExceeded: 'Attachment size is larger than 24 MB limit',

    logSizeTooLarge: ({size}: LogSizeParams) => `Log size exceeds the limit of ${size} MB. Please use "Save log" to download the log file instead.`,

    Also need to change in es.ts file

    OPTIONAL: We can remove space in here and here

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 17, 2024
  8. changed the title [-]Inconsistent display of measurement units[/-] [+][$250] Inconsistent display of measurement units[/+] on Dec 17, 2024
  9. melvin-bot commented on Dec 17, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 17, 2024
  11. melvin-bot commented on Dec 17, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  12. 26 remaining items

  13. melvin-bot commented on Dec 26, 2024

    @melvin-bot

    @shubham1206agra / @dukenv0307 @Christinadobrzyn @shubham1206agra / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Dec 31, 2024
  15. Christinadobrzyn commented on Jan 3, 2025

    @Christinadobrzyn
    Contributor

    Awesome! Payment day!

    Payment summary here -

    Contributor: @shubham1206agra paid $50 via Upwork (https://www.upwork.com/nx/wm/workroom/39384408/overview)
    Contributor+: @dukenv0307 owed $50 via NewDot

    @shubham1206agra do you want to me paid through Upwork or ND? Here's the Upwork offer if that's best.

    @dukenv0307 do we need a regression test for this?

  16. shubham1206agra commented on Jan 3, 2025

    @shubham1206agra
    Contributor

    @Christinadobrzyn Upwork please

  17. Christinadobrzyn commented on Jan 3, 2025

    @Christinadobrzyn
    Contributor

    Awesome thanks @shubham1206agra! I paid you in Upwork.

    @dukenv0307 can you let us know about a regression test, thanks!

  18. dukenv0307 commented on Jan 5, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/51104/files#r1903189485

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template

    Regression Test Proposal

    Test:

    1. Try uploading an avatar with an image larger than 6 MB.
    2. Try adding a attachment with a file larger than 24 MB.
    3. Consistent display of measurement units. For example: 24 MB (within the space between number and unit)

    Do we agree 👍 or 👎

  19. dukenv0307 commented on Jan 5, 2025

    @dukenv0307
    Contributor

    @Christinadobrzyn I completed the checklists

  20. Christinadobrzyn commented on Jan 6, 2025

    @Christinadobrzyn
    Contributor

    Thanks @dukenv0307! Here's the payment summary - please make sure to request payment in ND.

    #54226 (comment)

    Closing this as complete.

  21. moved this from Hold for Payment to Done in #expensify-bugson Jan 6, 2025
  22. JmillsExpensify commented on Jan 13, 2025

    @JmillsExpensify
    Contributor

    $50 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions