You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-02] [$50] Inconsistent display of measurement units #54226
Version Number: 9.0.76-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dukenv0307 Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:
Try uploading an avatar with an image larger than 6 MB.
Try adding a attachment with a file larger than 24 MB.
Observe the error displayed.
Expected Result:
Consistent display of measurement units
Actual Result:
We are displaying inconsistently "6MB" and "24 MB".
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@shubham1206agra / @dukenv0307@Christinadobrzyn@shubham1206agra / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 17, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dukenv0307 commentedon Dec 17, 2024
@Christinadobrzyn I can help take this issue as C+ since I have the context on it
shubham1206agra commentedon Dec 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent display of measurement units
What is the root cause of that problem?
In translation files
App/src/languages/en.ts
Line 512 in d86024e
App/src/languages/en.ts
Line 522 in d86024e
App/src/languages/en.ts
Line 1087 in d86024e
App/src/languages/en.ts
Line 1253 in d86024e
The translation of size is inconsistent.
What changes do you think we should make in order to solve the problem?
Make the above translations consistent. @jamesdeanexpensify can chime in here for the translations
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA since it is a UI change
What alternative solutions did you explore? (Optional)
NA
nyomanjyotisa commentedon Dec 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent display of measurement units
What is the root cause of that problem?
We are inconsistently create the translation copies
App/src/languages/en.ts
Line 1087 in d86024e
App/src/languages/en.ts
Line 512 in d86024e
What changes do you think we should make in order to solve the problem?
Add space before MB in the following copies, and its translation in .es file
App/src/languages/en.ts
Line 522 in d86024e
App/src/languages/en.ts
Line 1087 in d86024e
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
daledah commentedon Dec 17, 2024
Edited by proposal-police: This proposal was edited at 2024-12-17 02:40:04 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
We are displaying inconsistently "6MB" and "24 MB".
What is the root cause of that problem?
We are not consistent when displaying measurement units
App/src/languages/en.ts
Line 512 in d86024e
App/src/languages/en.ts
Line 522 in d86024e
What changes do you think we should make in order to solve the problem?
We can remove space before MB
App/src/languages/en.ts
Line 512 in d86024e
App/src/languages/en.ts
Line 1253 in d86024e
Also need to change in es.ts file
OPTIONAL: We can remove space in here and here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Inconsistent display of measurement units[/-][+][$250] Inconsistent display of measurement units[/+]melvin-bot commentedon Dec 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021869142033023958876
melvin-bot commentedon Dec 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)26 remaining items
melvin-bot commentedon Dec 26, 2024
@shubham1206agra / @dukenv0307 @Christinadobrzyn @shubham1206agra / @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Christinadobrzyn commentedon Jan 3, 2025
Awesome! Payment day!
Payment summary here -
Contributor: @shubham1206agra paid $50 via Upwork (https://www.upwork.com/nx/wm/workroom/39384408/overview)
Contributor+: @dukenv0307 owed $50 via NewDot
@shubham1206agra do you want to me paid through Upwork or ND? Here's the Upwork offer if that's best.
@dukenv0307 do we need a regression test for this?
shubham1206agra commentedon Jan 3, 2025
@Christinadobrzyn Upwork please
Christinadobrzyn commentedon Jan 3, 2025
Awesome thanks @shubham1206agra! I paid you in Upwork.
@dukenv0307 can you let us know about a regression test, thanks!
dukenv0307 commentedon Jan 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51104/files#r1903189485
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/457795
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dukenv0307 commentedon Jan 5, 2025
@Christinadobrzyn I completed the checklists
Christinadobrzyn commentedon Jan 6, 2025
Thanks @dukenv0307! Here's the payment summary - please make sure to request payment in ND.
#54226 (comment)
Closing this as complete.
JmillsExpensify commentedon Jan 13, 2025
$50 approved for @dukenv0307