You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-22] [$250] System message is shown in English #54397
Version Number: 9.0.77-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dukenv0307 Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:
Change the app language to Spanish
Create a new workspace
Go to more features -> enable Company Card
Upgrade this workspace to the Control Plan
Go to workspace admin room
Observe system messages
Expected Result:
System message is shown in Spanish
Actual Result:
System message is shown in English
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidencebug-resize.mp4Recording.861.mp4
Edited by proposal-police: This proposal was edited at 2024-12-20 14:04:17 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
System message is shown in English
What is the root cause of that problem?
We are not specially handling POLICYCHANGELOG_CORPORATE_UPGRADE type report action to provide translations so we are displaying the reportAction.message the BE returns
What changes do you think we should make in order to solve the problem?
We should add a translation to handle translation for POLICYCHANGELOG_CORPORATE_UPGRADE action types more of similar to CONST.REPORT.ACTIONS.TYPE.REJECTED and create a util that returns the translation like here
And then we should use this translation for:
Handle the case in PureReportActionItem here to display it
Handle the case in getReportName for chat thread header title here to align the thread header title with the report action content we are displaying in PureReportActionItem.
Note: On the PR phase we can also consider other related report actions like POLICYCHANGELOG_TEAM_DOWNGRADE too
We can also consider translating the Congrats ... whisper message too. Although it is ADDCOMMENT report action we can identify it via actorAccountID, whisperTo, and content of the message and display the translated copy instead 👍
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
@zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
changed the title [-][$250] System message is shown in English[/-][+][HOLD for payment 2025-01-22] [$250] System message is shown in English[/+]on Jan 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@zanyrenney@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Change the app language to Spanish
Create a new workspace
Go to more features -> enable Company Card
Upgrade this workspace to the Control Plan
Go to workspace profile -> Downgrade this workspace
Activity
melvin-bot commentedon Dec 19, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Dec 19, 2024
Edited by proposal-police: This proposal was edited at 2025-01-06 08:52:20 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
System message is shown in English
What is the root cause of that problem?
When we upgrade the workspace to the control plan, we don't add any report action to keep track of the change
What changes do you think we should make in order to solve the problem?
BE return action name is POLICYCHANGELOG_CORPORATE_UPGRADE
getCorporateUpgradeMessageand return translationAdd a case for this action here for the alternative text in LHN
Add a case in
ReportActionItemhere for the action inReportScreenAdd a case in here for the copy message
Note: we have a similar feature here is downgrade workspace we also need update system message
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
dukenv0307 commentedon Dec 20, 2024
@zanyrenney I have the prior context on this bug so I can help take it as C+
FitseTLT commentedon Dec 20, 2024
Edited by proposal-police: This proposal was edited at 2024-12-20 14:04:17 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
System message is shown in English
What is the root cause of that problem?
We are not specially handling POLICYCHANGELOG_CORPORATE_UPGRADE type report action to provide translations so we are displaying the reportAction.message the BE returns
What changes do you think we should make in order to solve the problem?
We should add a translation to handle translation for POLICYCHANGELOG_CORPORATE_UPGRADE action types more of similar to
CONST.REPORT.ACTIONS.TYPE.REJECTEDand create a util that returns the translation like hereAnd then we should use this translation for:
For the alternative text in LHN here
Handle the case in PureReportActionItem here to display it
Handle the case in getReportName for chat thread header title here to align the thread header title with the report action content we are displaying in PureReportActionItem.
And finally in here for copy to clipboard
Note: On the PR phase we can also consider other related report actions like
POLICYCHANGELOG_TEAM_DOWNGRADEtooWe can also consider translating the Congrats ... whisper message too. Although it is ADDCOMMENT report action we can identify it via actorAccountID, whisperTo, and content of the message and display the translated copy instead 👍
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
zanyrenney commentedon Dec 20, 2024
Nice find, thanks!
melvin-bot commentedon Dec 24, 2024
@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 26, 2024
@zanyrenney Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Dec 30, 2024
@zanyrenney Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Jan 1, 2025
@zanyrenney 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Jan 2, 2025
@zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Jan 3, 2025
@zanyrenney 12 days overdue now... This issue's end is nigh!
30 remaining items
[-][$250] System message is shown in English[/-][+][HOLD for payment 2025-01-22] [$250] System message is shown in English[/+]melvin-bot commentedon Jan 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 15, 2025
@dukenv0307 @zanyrenney @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon Jan 16, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/43822/files#r1917602936
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
zanyrenney commentedon Jan 22, 2025
https://github.com/Expensify/Expensify/issues/463464
zanyrenney commentedon Jan 22, 2025
Payment summary
@dukenv0307 requires payment through NewDot Manual Requests - please request $250 via ND requests.
@nkdengineer requires payment automatic offer (Contributor) - paid $250 via upwork.
JmillsExpensify commentedon Feb 20, 2025
$250 approved for @dukenv0307