Skip to content

[HOLD for payment 2025-01-22] [$250] System message is shown in English #54397

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.77-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

  1. Change the app language to Spanish
  2. Create a new workspace
  3. Go to more features -> enable Company Card
  4. Upgrade this workspace to the Control Plan
  5. Go to workspace admin room
  6. Observe system messages

Expected Result:

System message is shown in Spanish

Actual Result:

System message is shown in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
bug-resize.mp4
Recording.861.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021875253474674806164
  • Upwork Job ID: 1875253474674806164
  • Last Price Increase: 2025-01-03
  • Automatic offers:
    • nkdengineer | Contributor | 105614575
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 19, 2024
  2. melvin-bot commented on Dec 19, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Dec 19, 2024

    @nkdengineer
    Contributor

    Edited by proposal-police: This proposal was edited at 2025-01-06 08:52:20 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    System message is shown in English

    What is the root cause of that problem?

    When we upgrade the workspace to the control plan, we don't add any report action to keep track of the change

    What changes do you think we should make in order to solve the problem?

    BE return action name is POLICYCHANGELOG_CORPORATE_UPGRADE

    1. Create a new translation key for this action
    2. Create a util function in ReportUtils like getCorporateUpgradeMessage and return translation
    3. Use this function in some places below like we did with other actions
    • Add a case for this action here for the alternative text in LHN

    • Add a case in ReportActionItem here for the action in ReportScreen

    • Add a case in here for the copy message

    Note: we have a similar feature here is downgrade workspace we also need update system message

    Screenshot 2025-01-06 at 15 50 13

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    NA

  4. dukenv0307 commented on Dec 20, 2024

    @dukenv0307
    Contributor

    @zanyrenney I have the prior context on this bug so I can help take it as C+

  5. FitseTLT commented on Dec 20, 2024

    @FitseTLT
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-12-20 14:04:17 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    System message is shown in English

    What is the root cause of that problem?

    We are not specially handling POLICYCHANGELOG_CORPORATE_UPGRADE type report action to provide translations so we are displaying the reportAction.message the BE returns

    What changes do you think we should make in order to solve the problem?

    We should add a translation to handle translation for POLICYCHANGELOG_CORPORATE_UPGRADE action types more of similar to CONST.REPORT.ACTIONS.TYPE.REJECTED and create a util that returns the translation like here
    And then we should use this translation for:

    1. For the alternative text in LHN here

    2. Handle the case in PureReportActionItem here to display it

    3. Handle the case in getReportName for chat thread header title here to align the thread header title with the report action content we are displaying in PureReportActionItem.

    4. And finally in here for copy to clipboard

    Note: On the PR phase we can also consider other related report actions like POLICYCHANGELOG_TEAM_DOWNGRADE too
    We can also consider translating the Congrats ... whisper message too. Although it is ADDCOMMENT report action we can identify it via actorAccountID, whisperTo, and content of the message and display the translated copy instead 👍

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

  6. zanyrenney commented on Dec 20, 2024

    @zanyrenney
    Contributor

    Nice find, thanks!

  7. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. melvin-bot commented on Dec 26, 2024

    @melvin-bot

    @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

  9. melvin-bot commented on Dec 30, 2024

    @melvin-bot

    @zanyrenney Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  10. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    @zanyrenney 10 days overdue. Is anyone even seeing these? Hello?

  11. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  12. melvin-bot commented on Jan 3, 2025

    @melvin-bot

    @zanyrenney 12 days overdue now... This issue's end is nigh!

  13. 30 remaining items

  14. changed the title [-][$250] System message is shown in English[/-] [+][HOLD for payment 2025-01-22] [$250] System message is shown in English[/+] on Jan 15, 2025
  15. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-22. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    @dukenv0307 @zanyrenney @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. dukenv0307 commented on Jan 16, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/43822/files#r1917602936

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Change the app language to Spanish
    2. Create a new workspace
    3. Go to more features -> enable Company Card
    4. Upgrade this workspace to the Control Plan
    5. Go to workspace profile -> Downgrade this workspace
    6. Go to workspace admin room
    7. Observe system messages
    8. Verify that: System message is shown in Spanish

    Do we agree 👍 or 👎

  19. zanyrenney commented on Jan 22, 2025

    @zanyrenney
    Contributor
  20. zanyrenney commented on Jan 22, 2025

    @zanyrenney
    Contributor

    Payment summary

    @dukenv0307 requires payment through NewDot Manual Requests - please request $250 via ND requests.
    @nkdengineer requires payment automatic offer (Contributor) - paid $250 via upwork.

  21. JmillsExpensify commented on Feb 20, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions