Skip to content

[Due for payment 2025-02-28] Selection gets removed after navigating to a single per diem option #54498

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+nl895@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Workspace Settings

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace
  3. Enable per diem
  4. Import a spreadsheet for per diem
  5. Select all
  6. Click on one of the per diem rates

Expected Result:

Selection doesn't reset. (App works consistently with the categories page)

Actual Result:

Selection resets

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701567_1735002522319.bandicam_2024-12-24_04-05-50-424.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 24, 2024
  2. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Dec 24, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. NJ-2020 commented on Dec 24, 2024

    @NJ-2020
    Contributor

    I think this could be NAB because in this issue we're only fixing for categories page only

    If we want to fix inside the per-diem page also, we can do the same as we do for categories page

  7. jasperhuangg commented on Dec 24, 2024

    @jasperhuangg
    Contributor

    @truph01 Care to take on this issue as well?

  8. 55 remaining items

  9. Christinadobrzyn commented on Feb 24, 2025

    @Christinadobrzyn
    Contributor

    Ah thank you! @allroundexperts should we have a regression test for this?

  10. melvin-bot commented on Feb 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@Christinadobrzyn)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. allroundexperts commented on Mar 3, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I wasn't able to pinpoint the exact PR which caused this. Seemed like this was an issue since the start of this feature.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/476310

    Regression Test Proposal

    Precondition:

    • N/A

    Test:

    1. Create a workspace
    2. Enable per diem
    3. Import a spreadsheet for per diem
    4. Select all
    5. Click on one of the per diem rates

    Verify that the selection doesn't reset.

    Do we agree 👍 or 👎

  12. Christinadobrzyn commented on Mar 3, 2025

    @Christinadobrzyn
    Contributor

    Regression test - https://github.com/Expensify/Expensify/issues/476310

    Payment summary here - #54498 (comment)

    Closing as complete, @allroundexperts please make sure to submit a payment request in New Expensify. thanks!

  13. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 3, 2025
  14. JmillsExpensify commented on Jun 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions