Skip to content

[HOLD for payment 2025-01-24] [$250] Compose box > Create - Pay {userName} emit no sound after click on Pay elsewhere #54725

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5396692
Email or phone of affected tester (no customers): testexpensify9+1@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.2, Desktop/Web | iOS Hybrid/mWeb Safari, iOS 18.2 | Samsung A22 mWeb Chrome
App Component: Other

Action Performed:

  1. Open the desktop app or go to: https://staging.new.expensify.com/
  2. Log in
  3. Go to 1:1 convo
  4. Click on '+' button in the compose box
  5. Click on 'Pay {userName}'
  6. Type any valid amount, click next
  7. Click on button 'Pay elsewhere'

Expected Result:

A success sound should be emitted right after clicking on ‘Pay elsewhere’.

Actual Result:

No sound is emitted after clicking on ‘Pay elsewhere’.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704803_1735745205628.Screen_Recording_2025-01-01_at_12.10.48_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021875191938779375502
  • Upwork Job ID: 1875191938779375502
  • Last Price Increase: 2025-01-03
  • Automatic offers:
    • rojiphil | Reviewer | 105611285
    • nkdengineer | Contributor | 105611286
Issue OwnerCurrent Issue Owner: @MitchExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 1, 2025
  2. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Jan 1, 2025

    @nkdengineer
    Contributor

    Edited by proposal-police: This proposal was edited at 2025-01-01 17:18:50 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    No sound is emitted after clicking on ‘Pay elsewhere’.

    What is the root cause of that problem?

    We pass shouldPlaySound as false in here

    What changes do you think we should make in order to solve the problem?

    We can pass shouldPlaySound as true or in case iouType === 'pay' or only in case paymentMethod === CONST.IOU.PAYMENT_TYPE.ELSEWHERE

    And add update logic here to play sound

            if (shouldPlaySound) {
                playSound(SOUNDS.DONE);
            }
            onSendMoney?.(paymentMethod);
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. MitchExpensify commented on Jan 3, 2025

    @MitchExpensify
    Contributor
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 3, 2025
  6. melvin-bot commented on Jan 3, 2025

    @melvin-bot
  7. changed the title [-]Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/-] [+][$250] Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/+] on Jan 3, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 3, 2025
  9. melvin-bot commented on Jan 3, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

  10. moved this to Bugs and Follow Up Issues in #expensify-bugson Jan 3, 2025
  11. rojiphil commented on Jan 6, 2025

    @rojiphil
    Contributor

    Reviewing now

  12. 22 remaining items

  13. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    @rojiphil @MitchExpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. MitchExpensify commented on Jan 18, 2025

    @MitchExpensify
    Contributor

    Payment summary:

    @rojiphil reminder on BZ steps

  15. MitchExpensify commented on Jan 18, 2025

    @MitchExpensify
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  16. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 21, 2025
  17. rojiphil commented on Jan 24, 2025

    @rojiphil
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Go to 1:1 chat
    2. Click on '+' button in the compose box
    3. Click on 'Pay {userName}'
    4. Type any valid amount, click next
    5. Click on button 'Pay elsewhere'
    6. Verify that: A success sound should be emitted right after clicking on ‘Pay elsewhere’.

    Do we agree 👍 or 👎

  18. rojiphil commented on Jan 24, 2025

    @rojiphil
    Contributor

    @MitchExpensify BZ checklist done. Just the payment is pending. Thanks.

  19. MitchExpensify commented on Jan 24, 2025

    @MitchExpensify
    Contributor

    @rojiphil please accept this offer as a next step: https://www.upwork.com/nx/wm/offer/105611285
    @nkdengineer - paid!

  20. rojiphil commented on Jan 24, 2025

    @rojiphil
    Contributor

    please accept this offer as a next step: https://www.upwork.com/nx/wm/offer/105611285

    @MitchExpensify Oh! I missed this. I just accepted the offer. Thanks.

  21. MitchExpensify commented on Jan 27, 2025

    @MitchExpensify
    Contributor

    Paid, thanks!

  22. moved this from Hold for Payment to Done in #expensify-bugson Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions