You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-24] [$250] Compose box > Create - Pay {userName} emit no sound after click on Pay elsewhere #54725
Version Number: 9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5396692 Email or phone of affected tester (no customers):testexpensify9+1@gmail.com Issue reported by: Applause Internal Team Device used: macOS Sequoia 15.2, Desktop/Web | iOS Hybrid/mWeb Safari, iOS 18.2 | Samsung A22 mWeb Chrome App Component: Other
if (shouldPlaySound) {
playSound(SOUNDS.DONE);
}
onSendMoney?.(paymentMethod);
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/-][+][$250] Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/+]on Jan 3, 2025
@rojiphil@MitchExpensify@rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Go to 1:1 chat
Click on '+' button in the compose box
Click on 'Pay {userName}'
Type any valid amount, click next
Click on button 'Pay elsewhere'
Verify that: A success sound should be emitted right after clicking on ‘Pay elsewhere’.
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Jan 1, 2025
Edited by proposal-police: This proposal was edited at 2025-01-01 17:18:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
No sound is emitted after clicking on ‘Pay elsewhere’.
What is the root cause of that problem?
We pass
shouldPlaySoundas false in hereApp/src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Line 666 in 701c68d
What changes do you think we should make in order to solve the problem?
We can pass
shouldPlaySoundas true or in caseiouType === 'pay'or only in casepaymentMethod === CONST.IOU.PAYMENT_TYPE.ELSEWHEREApp/src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Line 666 in 701c68d
And add update logic here to play sound
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
MitchExpensify commentedon Jan 3, 2025
Clarifying what's expected here: https://expensify.slack.com/archives/C03U7DCU4/p1735914966075309
melvin-bot commentedon Jan 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021875191938779375502
[-]Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/-][+][$250] Compose box > Create - `Pay {userName}` emit no sound after click on `Pay elsewhere`[/+]melvin-bot commentedon Jan 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (
External)rojiphil commentedon Jan 6, 2025
Reviewing now
22 remaining items
melvin-bot commentedon Jan 17, 2025
@rojiphil @MitchExpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
MitchExpensify commentedon Jan 18, 2025
Payment summary:
@rojiphil reminder on BZ steps
MitchExpensify commentedon Jan 18, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/464308
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
rojiphil commentedon Jan 24, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
rojiphil commentedon Jan 24, 2025
@MitchExpensify BZ checklist done. Just the payment is pending. Thanks.
MitchExpensify commentedon Jan 24, 2025
@rojiphil please accept this offer as a next step: https://www.upwork.com/nx/wm/offer/105611285
@nkdengineer - paid!
rojiphil commentedon Jan 24, 2025
@MitchExpensify Oh! I missed this. I just accepted the offer. Thanks.
MitchExpensify commentedon Jan 27, 2025
Paid, thanks!