Skip to content

Wallet - Error indicating a selection is required is not shown in account selection page #54738

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.80-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings

Action Performed:

  1. Login to NewDot.
  2. Go to Settings > Wallet > Add bank account.
  3. Click Add bank account.
  4. Select any county other than United States(or select India)
  5. Click Next.
  6. Enter Valid Account number and IFSC > Next
  7. On the account type selector page Click Next before making a selection.

Expected Result:

Error indicating a selection is required is shown

Actual Result:

Clicking Next before making a selection does not show Error indicating a selection is required

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704931_1735790799825.Screen_Recording_2025-01-02_at_7.02.24_in_the_morning.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 2, 2025
  2. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 2, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nkdengineer commented on Jan 2, 2025

    @nkdengineer
    Contributor

    Edited by proposal-police: This proposal was edited at 2025-01-02 09:16:24 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Clicking Next before making a selection does not show Error indicating a selection is required

    What is the root cause of that problem?

    We add props showConfirmButton in this SelectionList

    it will always show confirm button

    What changes do you think we should make in order to solve the problem?

    We can do the same way that we did with WorkspaceWorkflowsApprovalsApproverPage here

    1. Remove showConfirmButton, onConfirm and confirmButtonText props
    2. Add prop footerContent={footerButton}
    3. Define footerButton
        const button = useMemo(() => {
            const buttonText = isEditing ? translate('common.confirm') : translate('common.next')
            return (
                <FormAlertWithSubmitButton
                    isDisabled={!currentAccountType}
                    buttonText={buttonText}
                    onSubmit={onAccountTypeSelected}
                    containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}
                    enabledWhenOffline
                />
            );
        }, [currentAccountType, isEditing, onAccountTypeSelected, styles.flexBasisAuto, styles.flexGrow0, styles.flexReset, styles.flexShrink0, translate]);
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    Result

    Screen.Recording.2025-01-02.at.16.21.40.mov
  7. youssef-lr commented on Jan 2, 2025

    @youssef-lr
    Contributor

    @shubham1206agra can you take a look at the proposal above please?

  8. lschurr commented on Jan 3, 2025

    @lschurr
    Contributor

    @youssef-lr should we assign this one to @shubham1206agra?

  9. youssef-lr commented on Jan 6, 2025

    @youssef-lr
    Contributor
  10. shubham1206agra commented on Jan 6, 2025

    @shubham1206agra
    Contributor

    Already being taken care of in follow up PR

  11. isagoico commented on Jan 6, 2025

    @isagoico

    We can't try to reproduce anymore with the revert #54729 as the same flow is not available.

  12. shubham1206agra commented on Jan 6, 2025

    @shubham1206agra
    Contributor

    @isagoico Please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions