You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wallet - Error indicating a selection is required is not shown in account selection page #54738
Version Number: v9.0.80-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#52322 Email or phone of affected tester (no customers):dave0123seife@gmail.com Issue reported by: Applause Internal Team Device used: Mac 14.5/ Chrome App Component: User Settings
Action Performed:
Login to NewDot.
Go to Settings > Wallet > Add bank account.
Click Add bank account.
Select any county other than United States(or select India)
Click Next.
Enter Valid Account number and IFSC > Next
On the account type selector page Click Next before making a selection.
Expected Result:
Error indicating a selection is required is shown
Actual Result:
Clicking Next before making a selection does not show Error indicating a selection is required
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 2, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 2, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon Jan 2, 2025
Edited by proposal-police: This proposal was edited at 2025-01-02 09:16:24 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking Next before making a selection does not show Error indicating a selection is required
What is the root cause of that problem?
We add props
showConfirmButtonin this SelectionListit will always show confirm button
What changes do you think we should make in order to solve the problem?
We can do the same way that we did with
WorkspaceWorkflowsApprovalsApproverPagehereshowConfirmButton,onConfirmandconfirmButtonTextpropsfooterContent={footerButton}footerButtonWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Result
Screen.Recording.2025-01-02.at.16.21.40.mov
youssef-lr commentedon Jan 2, 2025
@shubham1206agra can you take a look at the proposal above please?
lschurr commentedon Jan 3, 2025
@youssef-lr should we assign this one to @shubham1206agra?
youssef-lr commentedon Jan 6, 2025
bump @shubham1206agra
shubham1206agra commentedon Jan 6, 2025
Already being taken care of in follow up PR
isagoico commentedon Jan 6, 2025
We can't try to reproduce anymore with the revert #54729 as the same flow is not available.
shubham1206agra commentedon Jan 6, 2025
@isagoico Please close this issue.