You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-21] [$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option #54864
The Upgrade option is displayed after selecting the "Categorize it" option in the actionable menu in the account without workspaces
Actual Result:
Hmm... it's not here is displayed after selecting the "Categorize it" option in the account where all workspaces were deleted. The modal with the Upgrade option is displayed after selecting the "Clear cache and restart" option in Troubleshoot
Edited by proposal-police: This proposal was edited at 2025-01-07 10:02:37 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hmm... it's not here is displayed after selecting the "Categorize it" option in the account where all workspaces were deleted. The modal with the Upgrade option is displayed after selecting the "Clear cache and restart" option in Troubleshoot
What is the root cause of that problem?
After we delete the default workspace, the activePolicy data still exists with three fields then we still go to the category page then the not found page appear based on AccessOrNotFoundWrapper
What changes do you think we should make in order to solve the problem?
We should use shouldShow policy function to check whether the policy is valid or not. That has already covered the personal policy and pending delete case.
if (PolicyUtils.shouldShowPolicy(activePolicy, false, currentUserEmail)) {
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/-][+][$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/+]on Jan 7, 2025
changed the title [-][$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/-][+][HOLD for payment 2025-01-21] [$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/+]on Jan 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@twisterdotcom@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Precondition: The user has only one active group workspace
Activity
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Jan 7, 2025
Edited by proposal-police: This proposal was edited at 2025-01-07 10:02:37 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hmm... it's not here is displayed after selecting the "Categorize it" option in the account where all workspaces were deleted. The modal with the Upgrade option is displayed after selecting the "Clear cache and restart" option in Troubleshoot
What is the root cause of that problem?
After we delete the default workspace, the
activePolicydata still exists with three fields then we still go to the category page then the not found page appear based onAccessOrNotFoundWrapperApp/src/libs/ReportUtils.ts
Line 8353 in 96280b8
What changes do you think we should make in order to solve the problem?
We should use
shouldShowpolicy function to check whether the policy is valid or not. That has already covered the personal policy and pending delete case.App/src/libs/ReportUtils.ts
Line 8353 in 96280b8
We also need to do the same here to filter out the invalid policy above
App/src/libs/ReportUtils.ts
Line 8348 in 96280b8
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jan 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021876588733605475971
[-]Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/-][+][$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/+]melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)twisterdotcom commentedon Jan 7, 2025
Recreated in Chrome too.
54864.mp4
ZhenjaHorbach commentedon Jan 7, 2025
Yeah
Agree
This can easily be reproduced on the web also
@mkzie2
And thanks for your proposal !
The proposal makes sense to me and works well !
🎀👀🎀 C+ reviewed
Plus I also noticed that we also use the old logic in
hasNoPolicyOtherThanPersonalTypeutil that is not used anywhere elseApp/src/libs/PolicyUtils.ts
Lines 1101 to 1106 in cf9a023
So we can remove it as well
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
10 remaining items
jjcoffee commentedon Jan 13, 2025
This is a dupe of #53659.
twisterdotcom commentedon Jan 13, 2025
We're going to go ahead with this one for the fix, and @jjcoffee and @truph01 will handle unit tests in #53659
[-][$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/-][+][HOLD for payment 2025-01-21] [$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option[/+]melvin-bot commentedon Jan 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 14, 2025
@ZhenjaHorbach @twisterdotcom @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ZhenjaHorbach commentedon Jan 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52737/files#r1922352573
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Precondition: The user has only one active group workspace
Do we agree 👍 or 👎
twisterdotcom commentedon Jan 21, 2025
Payment Summary: