You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-18] [$250] Category receipt required amount is displaying the wrong default value. #54916
Version Number: v9.0.81-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@VictoriaExpensify Slack conversation (hyperlinked to channel name): #expense
Action Performed:
Go to new.expensify.com
Create a workspace
Go to More features > Enable Rules > Upgrade
Go to Rules
Observe the receipt required amount is set to £25.00
Go to Categories
Click on a category value in the table to open the settings in the RHP
Observe the "require receipts over" default is set to £2000.00
Create and submit a manual expense on the workspace for £29.00 without a receipt
Observe the violation for receipts being required for expenses over £25.00
Expected Result:
The default in step 8 should be displayed as £25.00 to match the receipt required amount set on the workspace.
Actual Result:
The default in step 8 is displayed as £2000.00.
Note: It seems like we're displaying the max expense amount value instead, perhaps here.
Workaround:
Yes, the limit is correctly set to the workspace default on the backend, it's a display issue showing it as the wrong value in the category settings page.
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Category receipt required amount is displaying the wrong default value. [/-][+][$250] Category receipt required amount is displaying the wrong default value. [/+]on Jan 7, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Category receipt required amount is displaying the wrong default value. [/-][+][$250] Category receipt required amount is displaying the wrong default value. [/+]melvin-bot commentedon Jan 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021876762664887061908
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)truph01 commentedon Jan 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/libs/CategoryUtils.ts
Line 39 in f1cede9
we are using
policy?.maxExpenseAmount.What changes do you think we should make in order to solve the problem?
policy?.maxExpenseAmountNoReceiptinstead:App/src/pages/workspace/categories/CategoryRequireReceiptsOverPage.tsx
Line 48 in f1cede9
as well.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
shubham1206agra commentedon Jan 8, 2025
@truph01's proposal looks good to me.
🎀👀🎀 C+ reviewed
melvin-bot commentedon Jan 8, 2025
Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
20 remaining items
laurenreidexpensify commentedon Jan 17, 2025
Submitted test to be added to TestRail
laurenreidexpensify commentedon Jan 17, 2025
@shubham1206agra @truph01 can you confirm if you have accepted any offers in Upwork yet?
shubham1206agra commentedon Jan 17, 2025
@laurenreidexpensify I accepted the offer
laurenreidexpensify commentedon Jan 21, 2025
Note for myself- Upwork links being weird - checking internally https://expensify.slack.com/archives/C01SKUP7QR0/p1737447436443629
dylanexpensify commentedon Jan 21, 2025
Payments complete!
laurenreidexpensify commentedon Jan 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
laurenreidexpensify commentedon Jan 21, 2025
@shubham1206agra pls complete the checklist ^^
shubham1206agra commentedon Jan 21, 2025
@laurenreidexpensify Already done it here #54916 (comment)
laurenreidexpensify commentedon Jan 22, 2025
@shubham1206agra oh my sorry! i even already created the regression test 🤦 we got there ha!