Skip to content

[Due for payment 2025-03-10] [Due for payment 2025-03-05] [HOLD #55006/#55007][Manager McTest] Add the Manager McTest Tooltips/Recipient to Manual/Distance Flow #55009

Closed

Description

@grgia

⚠️ ON HOLD ⚠️ 1/2

Design Doc Section

Details

Validation: User sees Manager as a recipient if they meet Beta/NVP reqs and are in the Manual/Distance/Scan receipt flow. User may see the follow up tooltips if they did not dismiss the main tooltip yet.

Activity

  1. added and removed on Jan 9, 2025
  2. changed the title [-][HOLD #55006/#55007][Manager McTest] Implement the new flow for Manual/Distance (add tooltips, submit to ManagerMcTest)[/-] [+][HOLD #55006/#55007][Manager McTest] Add the Manager McTest Tooltips/Recipient to Manual/Distance Flow[/+] on Jan 10, 2025
  3. JKobrynski commented on Jan 10, 2025

    @JKobrynski
    Contributor

    Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

  4. grgia commented on Jan 24, 2025

    @grgia
    ContributorAuthor

    on HOLD

  5. grgia commented on Feb 6, 2025

    @grgia
    ContributorAuthor

    Not overdue, on hold

  6. 27 remaining items

  7. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  8. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @JKobrynski is from an agency-contributor and not due payment
    • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@laurenreidexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. laurenreidexpensify commented on Mar 11, 2025

    @laurenreidexpensify
    Contributor

    @grgia can you you confirm the fee for @DylanDylann - is this $250? Thanks

  10. laurenreidexpensify commented on Mar 11, 2025

    @laurenreidexpensify
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  11. laurenreidexpensify commented on Mar 11, 2025

    @laurenreidexpensify
    Contributor

    @DylanDylann @JKobrynski can we please get this filled out? Thanks!

  12. DylanDylann commented on Mar 11, 2025

    @DylanDylann
    Contributor

    @grgia Do we require the regression test on this issue?

  13. grgia commented on Mar 11, 2025

    @grgia
    ContributorAuthor

    @DylanDylann yes for the tooltips part

  14. DylanDylann commented on Mar 12, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: New Feature, not a bug

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Login in a new account
    2. Open FAB
    3. Select Create Expense (we can select any request type: manual, scan, distance)
    4. When on Scan tab verify that tooltip for trying out testing receipt is visible
    5. Go to select participant page
    6. Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
    7. Select Manager McTest
    8. On confirmation page verify that the tooltip above confirm button is visible

    Do we agree 👍 or 👎

  15. laurenreidexpensify commented on Mar 13, 2025

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ $250 offer sent in Upwork

  16. laurenreidexpensify commented on Mar 17, 2025

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ $250 paid in Upwork @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions