You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-19] [$250] Debug - Rooms that deny access to post are listed in list of contacts to share log data #55012
Version Number: v9.0.82-4 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Windows 11/ Chrome, Android 13/ Chrome, Tecno Spark 20/ Android 13 App Component: User Settings
Action Performed:
Pre-condition: Be a member of a workspace with more than 2 members
Sign in to NewDot
Navigate to Account settings > Troubleshoot
Enable client side logging
Navigate to view client side logging
Click on share
Expected Result:
List of accounts and workspace that the user can send messages to are shown.
Actual Result:
Rooms that the user cannot send messages to like #announce room of another workspace are included in the list of accounts to share to.
What changes do you think we should make in order to solve the problem?
We need to add a new option to getValidOptions whether to filter out read-only report or not. We pass it as true from getShareLogOptions. In getValidOptions, we filter it out using the condition from the ReportFooter.
function getShareLogOptions(options: OptionList, betas: Beta[] = []): Options {
return getValidOptions(options, {
betas,
includeMultipleParticipantReports: true,
includeP2P: true,
forcePolicyNamePreview: true,
includeOwnedWorkspaceChats: true,
includeSelfDM: true,
includeThreads: true,
isReservedRoomName: true, // add this line
isArchivedRoom: true, // add this line
});
}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We need to test if getShareLogOptions data does not include isReservedRoomName and isArchivedRoom.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Working on testing this but need to make a new test account because my current ones have too many workspaces so it's hard to tell which in the list I shouldn't have access too.
@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Jan 9, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Jan 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Announce room is shown on the share log list even though it's not writable.
What is the root cause of that problem?
Currently, we don't have any filter to filter out read-only report.
App/src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx
Line 40 in df73b07
What changes do you think we should make in order to solve the problem?
We need to add a new option to getValidOptions whether to filter out read-only report or not. We pass it as true from getShareLogOptions. In getValidOptions, we filter it out using the condition from the ReportFooter.
App/src/pages/home/report/ReportFooter.tsx
Lines 115 to 116 in df73b07
App/src/libs/OptionsListUtils.ts
Lines 1174 to 1191 in df73b07
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We need to test getShareLogOptions that it correctly filter out any read-only report (dummy list)
huult commentedon Jan 9, 2025
Edited by proposal-police: This proposal was edited at 2025-01-09 17:00:39 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Rooms that deny access to post are listed in list of contacts to share log data
What is the root cause of that problem?
We do not filter valid options for the share log list.
App/src/pages/settings/AboutPage/ShareLogList/BaseShareLogList.tsx
Line 30 in e68f0a8
What changes do you think we should make in order to solve the problem?
To resolve this issue, we should add a new condition to check if isReservedRoomName is true, then filter out the option list.
App/src/libs/OptionsListUtils.ts
Line 1142 in 98bb043
add
App/src/libs/OptionsListUtils.ts
Line 1214 in 98bb043
add:
if (isReservedRoomName && ValidationUtils.isReservedRoomName(option.text)) { return false; } if (isArchivedRoom && ReportUtils.isArchivedRoom(option)) { return false; } ...App/src/libs/OptionsListUtils.ts
Line 1369 in 98bb043
update to:
function getShareLogOptions(options: OptionList, betas: Beta[] = []): Options { return getValidOptions(options, { betas, includeMultipleParticipantReports: true, includeP2P: true, forcePolicyNamePreview: true, includeOwnedWorkspaceChats: true, includeSelfDM: true, includeThreads: true, isReservedRoomName: true, // add this line isArchivedRoom: true, // add this line }); }What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We need to test if getShareLogOptions data does not include isReservedRoomName and isArchivedRoom.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jan 13, 2025
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jan 15, 2025
@strepanier03 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Jan 17, 2025
@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
strepanier03 commentedon Jan 18, 2025
Working on testing this but need to make a new test account because my current ones have too many workspaces so it's hard to tell which in the list I shouldn't have access too.
melvin-bot commentedon Jan 21, 2025
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jan 23, 2025
@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
58 remaining items
parasharrajat commentedon Feb 18, 2025
Payment requested
bernhardoj commentedon Feb 18, 2025
Requested in ND.
luacmartins commentedon Feb 18, 2025
Seems like we're good to close this one?
parasharrajat commentedon Feb 18, 2025
We need a payment summary cc: @strepanier03
melvin-bot commentedon Feb 19, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon Feb 19, 2025
Today is the payment release date so I am taking care of this now.
strepanier03 commentedon Feb 19, 2025
I made the reg test request.
strepanier03 commentedon Feb 19, 2025
Payment Summary
strepanier03 commentedon Feb 19, 2025
Payment summary here, I'm closing now.
JmillsExpensify commentedon Feb 20, 2025
$250 approved for @bernhardoj
JmillsExpensify commentedon Feb 21, 2025
$250 approved for @parasharrajat