Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.82-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): expensify-bugs
Action Performed:
- Submit a receipt expense which has blank page after 1/3 of the page
- Compare the receipt display in the expense view and the expense preview.
- Observe that the preview shows a different portion of the receipt (often blank).
Expected Result:
The same subset of the receipt (preferably the top portion) should be displayed consistently in both the expense view and the expense preview.
Actual Result:
The expense view correctly shows the top portion of the receipt.
The expense preview appears to display a lower section, which can sometimes be blank, leading to a poor user experience.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
i_39d2d9f8dac03e8fe6a45134aee2a9a706c8bd7b-2025-01-09 17_08_50.746.pdf
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021879333035263669594
- Upwork Job ID: 1879333035263669594
- Last Price Increase: 2025-01-15
- Automatic offers:
- brunovjk | Reviewer | 105773591
- Krishna2323 | Contributor | 105773593
Issue Owner
Current Issue Owner: @adelekennedyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone


Activity
melvin-bot commentedon Jan 9, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Jan 10, 2025
Edited by proposal-police: This proposal was edited at 2025-01-10 03:10:33 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Align Receipt Image Consistently in Expense Preview and Expense View
What is the root cause of that problem?
shouldSetAspectRatioInStyleis false and due to this the aspect ratio style is not used and height is set to100%instead ofautoApp/src/components/ReportActionItem/ReportActionItemImages.tsx
Line 72 in 73fcb8b
App/src/components/Image/index.tsx
Line 140 in 73fcb8b
What changes do you think we should make in order to solve the problem?
ImageBehaviorContextProvider, we can use it for each image when we map throughshownImages.shouldSetAspectRatioInStylewill beshouldSetAspectRatioInStyle={numberOfShownImages === 1 ? true : Str.isPDF(filename ?? '')}.heightStyle, we would need to setminHeightStyle&maxHeightStyle.App/src/components/ReportActionItem/ReportActionItemImages.tsx
Line 71 in b77ff58
heightfromreportActionItemImagesshould also be removed.App/src/styles/index.ts
Line 4505 in b77ff58
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
shouldSetAspectRatioInStyle.ImageBehaviorContextProviderbecause it won't be required if we want toshouldSetAspectRatioInStyleas true fromReportActionItemImages.ImageBehaviorContextProviderwas introduced isn't reproducible after removing the context.melvin-bot commentedon Jan 13, 2025
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Align Receipt Image Consistently in Expense Preview and Expense View[/-][+][$250] Align Receipt Image Consistently in Expense Preview and Expense View[/+]melvin-bot commentedon Jan 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021879333035263669594
melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)15 remaining items
Krishna2323 commentedon Jan 22, 2025
@brunovjk, the PR is ready for review, only the android native video is not added cause the app crashes as soon as it is launched.
[-][$250] Align Receipt Image Consistently in Expense Preview and Expense View[/-][+][HOLD for payment 2025-02-04] [$250] Align Receipt Image Consistently in Expense Preview and Expense View[/+]melvin-bot commentedon Jan 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@brunovjk @adelekennedy @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brunovjk commentedon Feb 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR introduced the bug. (eg. a case wasn't considered)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
adelekennedy commentedon Feb 4, 2025
Contributor: @Krishna2323 paid $250 via Upwork
Contributor+: @brunovjk owed $250 via Upwork