You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-10] [$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates #55052
Version Number: 9.0.83-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+010108kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Distance rates.
Add one more distance rate if there is only one rate.
Select all rates via checkbox.
Click on the toggle on one of the rates to disable it.
Click on the dropdown button on the top right.
Expected Result:
The dropdown menu will show "Enable" option because now there is a disabled rate (it works this way with categories).
Actual Result:
The dropdown menu does not show "Enable" option after disabling a rate while selecting all rates.
It only appears after reselecting the rates.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
We can rely on rateID and value in the function updateDistanceRateEnabled to update selectedDistanceRates
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@thienlnam, @mountiny, I don't think we need to block deploy on this. It is a new feature (you couldn't really do this flow before the switch) and not very intrusive. That said, it is Friday, so we have until Monday to fix this.
changed the title [-][$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates[/-][+][Due for payment 2025-02-10] [$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates[/+]on Feb 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@paultsimura@abekkala@paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jan 10, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 10, 2025
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 10, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 10, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon Jan 10, 2025
Edited by proposal-police: This proposal was edited at 2025-01-10 08:28:21 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The dropdown menu does not show "Enable" option after disabling a rate while selecting all rates.
It only appears after reselecting the rates.
What is the root cause of that problem?
We are not updating
selectedDistanceRateswhen update distance rate statusApp/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx
Lines 101 to 118 in 219e66d
What changes do you think we should make in order to solve the problem?
We can rely on
rateIDandvaluein the function updateDistanceRateEnabled to updateselectedDistanceRatesWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Gonals commentedon Jan 10, 2025
#54451 Should have fixed this. Closing
9 remaining items
Gonals commentedon Jan 10, 2025
@thienlnam, @mountiny, I don't think we need to block deploy on this. It is a new feature (you couldn't really do this flow before the switch) and not very intrusive. That said, it is Friday, so we have until Monday to fix this.
@abzokhattab, @abekkala, this was caused by #54451
thienlnam commentedon Jan 10, 2025
Looks like I'll be able to deploy today, going to revert it since it is linked to another blocker as well
[-][$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates[/-][+][Due for payment 2025-02-10] [$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates[/+]melvin-bot commentedon Feb 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 3, 2025
@paultsimura @abekkala @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]