You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-04] [$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible #55238
Version Number: 9.0.85-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5456904 Email or phone of affected tester (no customers):testpayment935+881@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Precondition : NetSuite connection is established in the workspace.
Navigate to Hybrid android app
Navigate to Accounting
Click on Advanced
Scroll down to the "Custom form ID" and Notice the detail
Expected Result:
Detail Information for "Custom form ID" is visible fully
Actual Result:
The first line of detail Information for "Custom form ID" is only visible
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6714218_1736883969471.Screen_Recording_20250114_223148_Expensify.mp4
changed the title [-]Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/-][+][$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/+]on Jan 16, 2025
changed the title [-][$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/-][+][HOLD for payment 2025-02-04] [$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/+]on Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@greg-schroeder@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
User have NetSuite config.
Test:
Navigate to Hybrid android app
Navigate to Accounting
Click on Advanced
Scroll down to the "Custom form ID" and Notice the detail
Verify that the Custom form ID details section is fully visible.
Activity
melvin-bot commentedon Jan 14, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jan 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android- Netsuite- Advanced page for "custom form ID" detail is not visible
What is the root cause of that problem?
We are not using safe area padding bottom:
App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteAdvancedPage.tsx
Line 227 in 3fc71c9
so the custom form ID section is overlapped by the device navigation button.
What changes do you think we should make in order to solve the problem?
We should use
<ConnectionLayout shouldIncludeSafeAreaPaddingBottom ... />.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
[-]Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/-][+][$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/+]melvin-bot commentedon Jan 16, 2025
melvin-bot commentedon Jan 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021879917003425901165
melvin-bot commentedon Jan 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)hungvu193 commentedon Jan 16, 2025
@daledah 's proposal is straightforward. Please check other places that are using
ConnectionLayoutif we should include the padding-bottom as well.🎀 👀 🎀 C+ reviewed
11 remaining items
[-][$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/-][+][HOLD for payment 2025-02-04] [$125] Android- Netsuite- Advanced page for "custom form ID" detail is not visible[/+]melvin-bot commentedon Jan 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@hungvu193 @greg-schroeder @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
hungvu193 commentedon Feb 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/44723/files#r1938708993
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
greg-schroeder commentedon Feb 5, 2025
Payment summary:
Contributor: @daledah - $125 - Upwork
C+: @hungvu193 - $125 - ND Manual Request
greg-schroeder commentedon Feb 5, 2025
Filed regression test
garrettmknight commentedon Feb 11, 2025
$125 approved for @hungvu193