You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-05] [$250] Web - Distance - Create a distance to a user display an error message #55258
Version Number: v9.0.85-4 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#55220 Email or phone of affected tester (no customers):luongquocvu92@gmail.com Issue reported by: Applause Internal Team Device used: Windows 11 / Chrome App Component: Chat Report View
We have this PR to fix changing amount max length from 10 to 8 because with amount having more than 10 digits, manual request will fail in BE side.
I tried it in case distance request and there was no problem.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Web - Distance - Create a distance to a user display an error message[/-][+][$250] Web - Distance - Create a distance to a user display an error message[/+]on Jan 15, 2025
changed the title [-][$250] Web - Distance - Create a distance to a user display an error message[/-][+][HOLD for payment 2025-02-05] [$250] Web - Distance - Create a distance to a user display an error message[/+]on Jan 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@c3024@mallenexpensify@c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was a mismatch between the frontend and backend restrictions on the amount for different type of money requests. No PR can be held responsible
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical enough to warrant a discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Click on FAB
Click on Create expense
Click on Distance tab
Select locations so that distance between the locations is a very large number (like Oslo and Beijing).
Click the Next button.
Click on a user DM from the recent list or enter one.
Click on the Submit button
Verify that there is no error thrown and the request is submitted successfully.
Activity
melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Jan 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When creating a distance and submit to an individual user it displays an error message
What is the root cause of that problem?
We have CONST.IOU.AMOUNT_MAX_LENGTH = 8
With long distances and small currency values the amount here will have more than 8 digits and we get an error
App/src/components/MoneyRequestConfirmationList.tsx
Lines 790 to 793 in 7b9e55e
App/src/libs/MoneyRequestUtils.ts
Line 47 in 7b9e55e
What changes do you think we should make in order to solve the problem?
We should pass amount max length for case isDistanceRequest is 10
App/src/components/MoneyRequestConfirmationList.tsx
Lines 790 to 793 in 7b9e55e
We have this PR to fix changing amount max length from 10 to 8 because with amount having more than 10 digits, manual request will fail in BE side.
I tried it in case distance request and there was no problem.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Jan 15, 2025
WoLewicki commentedon Jan 15, 2025
@nkdengineer could you elaborate if the bump of mapbox caused this issue?
mountiny commentedon Jan 15, 2025
this does not seem related but maybe they just found it as they tested the flow more.
This is is not marked as deploy blocker so probably not
WoLewicki commentedon Jan 15, 2025
It was linked in my PR: #55220, that's why I'm asking. Thanks for info!
nkdengineer commentedon Jan 15, 2025
@WoLewicki It seems unrelated to your PR, this issue is about us setting
amountMaxLengthsmaller than the amount of the transaction.melvin-bot commentedon Jan 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021879503209059502176
[-]Web - Distance - Create a distance to a user display an error message[/-][+][$250] Web - Distance - Create a distance to a user display an error message[/+]18 remaining items
[-][$250] Web - Distance - Create a distance to a user display an error message[/-][+][HOLD for payment 2025-02-05] [$250] Web - Distance - Create a distance to a user display an error message[/+]melvin-bot commentedon Jan 29, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 29, 2025
@c3024 @mallenexpensify @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
c3024 commentedon Feb 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was a mismatch between the frontend and backend restrictions on the amount for different type of money requests. No PR can be held responsible
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical enough to warrant a discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
mallenexpensify commentedon Feb 6, 2025
Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @c3024 due $250 via NewDot
Test case created
Thx!
JmillsExpensify commentedon Mar 3, 2025
$250 approved for @c3024