Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorWeeklyKSv2KSv2
Description
Problem
The desktop builds seem to be flaky and sometimes they fail with similar errors to this:
Building Desktop App Archive Using Electron
• electron-builder version=25.0.0 os=23.6.0
• loaded configuration file=/Users/runner/work/App/App/config/electronBuilder.config.js
• executing @electron/rebuild electronVersion=32.2.3 arch=x64 buildFromSource=false appDir=desktop
• installing native dependencies arch=x64
• completed installing native dependencies
• packaging platform=darwin arch=x64 electron=32.2.3 appOutDir=desktop-build/mac-universal-x64-temp
⨯ Get "https://github.com/electron/electron/releases/download/v32.2.3/electron-v32.2.3-darwin-x64.zip": EOF
github.com/develar/app-builder/pkg/download.(*Downloader).follow.func1
/Users/runner/work/app-builder/app-builder/pkg/download/downloader.go:206
github.com/develar/app-builder/pkg/download.(*Downloader).follow
/Users/runner/work/app-builder/app-builder/pkg/download/downloader.go:234
github.com/develar/app-builder/pkg/download.(*Downloader).DownloadNoRetry
/Users/runner/work/app-builder/app-builder/pkg/download/downloader.go:[128](https://github.com/Expensify/App/actions/runs/12789494736/job/35653075390#step:5:129)
github.com/develar/app-builder/pkg/download.(*Downloader).Download
/Users/runner/work/app-builder/app-builder/pkg/download/downloader.go:112
github.com/develar/app-builder/pkg/electron.(*ElectronDownloader).doDownload
/Users/runner/work/app-builder/app-builder/pkg/electron/electronDownloader.go:203
github.com/develar/app-builder/pkg/electron.(*ElectronDownloader).Download
/Users/runner/work/app-builder/app-builder/pkg/electron/electronDownloader.go:188
github.com/develar/app-builder/pkg/electron.downloadElectron.func1.1
/Users/runner/work/app-builder/app-builder/pkg/electron/electronDownloader.go:73
github.com/develar/app-builder/pkg/util.MapAsyncConcurrency.func2
/Users/runner/work/app-builder/app-builder/pkg/util/async.go:68
runtime.goexit
/Users/runner/hostedtoolcache/go/1.21.11/arm64/src/runtime/asm_amd64.s:1650
⨯ /Users/runner/work/App/App/node_modules/app-builder-bin/mac/app-builder_amd64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1 failedTask=build stackTrace=Error: /Users/runner/work/App/App/node_modules/app-builder-bin/mac/app-builder_amd64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1
at ChildProcess.<anonymous> (/Users/runner/work/App/App/node_modules/builder-util/src/util.ts:255:14)
at Object.onceWrapper (node:events:633:26)
at ChildProcess.emit (node:events:518:28)
at maybeClose (node:internal/child_process:1104:16)
at Socket.<anonymous> (node:internal/child_process:456:11)
at Socket.emit (node:events:518:28)
at Pipe.<anonymous> (node:net:343:12)
Here is an example of the build run https://github.com/Expensify/App/actions/runs/12789494736/job/35653075390
Solution
Figure out why this is flaky and fix it
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021879526463505614944
- Upwork Job ID: 1879526463505614944
- Last Price Increase: 2025-01-15
Issue Owner
Current Issue Owner: @alexpensifyMetadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorWeeklyKSv2KSv2
Type
Projects
- StatusShow more project fieldsDone
Activity
[-]Desktop builds sometimes failing[/-][+][$250] Desktop builds sometimes failing[/+]melvin-bot commentedon Jan 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021879526463505614944
melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)[-][$250] Desktop builds sometimes failing[/-][+][HOLD for payment 2025-02-04] [$250] Desktop builds sometimes failing[/+]melvin-bot commentedon Jan 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@sobitneupane @alexpensify @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon Jan 29, 2025
I believe this was resolved an no need for payments