Skip to content

Workspace - Error when inviting members to the workspace #55276

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.86-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #55198
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click Invite member.
  4. Select a few members > Next.
  5. On confirmation page, select Admin role.
  6. Click Invite.

Expected Result:

Members should be invited without issue.

Actual Result:

Error when inviting members to the workspace

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6714803_1736951887307.20250115_223617.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 15, 2025
  2. github-actions commented on Jan 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    looking into this; will attempt to reproduce locally but I need to rebuild my vm so it might be a little bit

  7. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    I am not able to replicate this on staging or locally. Everything seems to work fine?

  8. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    @IuliiaHerets is it possible to retest this? Both @srikarparsi and I couldn't reproduce on staging or locally.

  9. izarutskaya commented on Jan 15, 2025

    @izarutskaya

    Tester still can reproduce the issue with Gmail and Expensifail accounts

    20250116_033423.mp4
    20250116_033228.mp4
  10. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    Okay thank you! I was able to replicate. It looks like the error is that the backend is trying to create an #announce channel with optimisticAnnounceChatReportID but when it tries to do that, it gets a 402 Invalid reportID error from that reportID here.

    Maybe we changed how we calculate the optimistic report? If not, this might be backend...

  11. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    I think this is a backend race condition that wasn't visible until we had this functionality in ND. I think the best path for now might be to revert the PR, and take a look at the BE, since I don't see any obvious fixes yet.

  12. parasharrajat commented on Jan 15, 2025

    @parasharrajat
    Member

    I didn't see this issue during my testing. Does this happen with a new user email?

  13. parasharrajat commented on Jan 15, 2025

    @parasharrajat
    Member

    If you think the backend will take time, then we can revert and then recreate the PR when backend is fixed.

  14. dangrous commented on Jan 15, 2025

    @dangrous
    Contributor

    so re: testing - for me it had to be a fresh workspace, and adding two admins at once - not sure if that was one of the cases you had tried? I probably wouldn't have thought about that particular one

  15. parasharrajat commented on Jan 16, 2025

    @parasharrajat
    Member

    OK, I was able to reproduce this. It is completely a backend issue. Do you think we can get someone assigned to it to fix the backend?

    This is not a deploy blocker as nothing breaks on the app. User can invite again. @dangrous We don't need to revert the other PR.

  16. parasharrajat commented on Jan 16, 2025

    @parasharrajat
    Member

    Let's remove the DP label. cc: @dangrous @bfitzexpensify

  17. dangrous commented on Jan 16, 2025

    @dangrous
    Contributor

    Okay I'm 99% of the way to figuring it out, we're switching the optimisticAnnounceReportID and the optimisticAnnounceReportActionID on the backend somewhere in PHP, which breaks things.

    This is definitely not frontend, as you said @parasharrajat. I don't love deploying a feature that doesn't work, but I guess it's fine? What do you think, @bfitzexpensify ? Should we hold until I find the cause and cp the fix (probably 1-2 hours max)? Or go ahead

  18. dangrous commented on Jan 16, 2025

    @dangrous
    Contributor
  19. dangrous commented on Jan 16, 2025

    @dangrous
    Contributor

    we're CP-ing it to staging and then prod, so should be pretty quick to solve this

  20. dangrous commented on Jan 16, 2025

    @dangrous
    Contributor

    this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions