You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - Error when inviting members to the workspace #55276
Version Number: 9.0.86-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#55198 Email or phone of affected tester (no customers): Mac 15.0 / Chrome Issue reported by: Applause Internal Team Device used:applausetester+100106kh@applause.expensifail.com App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Okay thank you! I was able to replicate. It looks like the error is that the backend is trying to create an #announce channel with optimisticAnnounceChatReportID but when it tries to do that, it gets a 402 Invalid reportID error from that reportID here.
Maybe we changed how we calculate the optimistic report? If not, this might be backend...
I think this is a backend race condition that wasn't visible until we had this functionality in ND. I think the best path for now might be to revert the PR, and take a look at the BE, since I don't see any obvious fixes yet.
so re: testing - for me it had to be a fresh workspace, and adding two admins at once - not sure if that was one of the cases you had tried? I probably wouldn't have thought about that particular one
Okay I'm 99% of the way to figuring it out, we're switching the optimisticAnnounceReportID and the optimisticAnnounceReportActionID on the backend somewhere in PHP, which breaks things.
This is definitely not frontend, as you said @parasharrajat. I don't love deploying a feature that doesn't work, but I guess it's fine? What do you think, @bfitzexpensify ? Should we hold until I find the cause and cp the fix (probably 1-2 hours max)? Or go ahead
Activity
github-actions commentedon Jan 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 15, 2025
💬 A slack conversation has been started in #expensify-open-source
dangrous commentedon Jan 15, 2025
looking into this; will attempt to reproduce locally but I need to rebuild my vm so it might be a little bit
dangrous commentedon Jan 15, 2025
I am not able to replicate this on staging or locally. Everything seems to work fine?
dangrous commentedon Jan 15, 2025
@IuliiaHerets is it possible to retest this? Both @srikarparsi and I couldn't reproduce on staging or locally.
izarutskaya commentedon Jan 15, 2025
Tester still can reproduce the issue with Gmail and Expensifail accounts
20250116_033423.mp4
20250116_033228.mp4
dangrous commentedon Jan 15, 2025
Okay thank you! I was able to replicate. It looks like the error is that the backend is trying to create an #announce channel with
optimisticAnnounceChatReportIDbut when it tries to do that, it gets a402 Invalid reportIDerror from that reportID here.Maybe we changed how we calculate the optimistic report? If not, this might be backend...
dangrous commentedon Jan 15, 2025
I think this is a backend race condition that wasn't visible until we had this functionality in ND. I think the best path for now might be to revert the PR, and take a look at the BE, since I don't see any obvious fixes yet.
parasharrajat commentedon Jan 15, 2025
I didn't see this issue during my testing. Does this happen with a new user email?
parasharrajat commentedon Jan 15, 2025
If you think the backend will take time, then we can revert and then recreate the PR when backend is fixed.
dangrous commentedon Jan 15, 2025
so re: testing - for me it had to be a fresh workspace, and adding two admins at once - not sure if that was one of the cases you had tried? I probably wouldn't have thought about that particular one
parasharrajat commentedon Jan 16, 2025
OK, I was able to reproduce this. It is completely a backend issue. Do you think we can get someone assigned to it to fix the backend?
This is not a deploy blocker as nothing breaks on the app. User can invite again. @dangrous We don't need to revert the other PR.
parasharrajat commentedon Jan 16, 2025
Let's remove the DP label. cc: @dangrous @bfitzexpensify
dangrous commentedon Jan 16, 2025
Okay I'm 99% of the way to figuring it out, we're switching the optimisticAnnounceReportID and the optimisticAnnounceReportActionID on the backend somewhere in PHP, which breaks things.
This is definitely not frontend, as you said @parasharrajat. I don't love deploying a feature that doesn't work, but I guess it's fine? What do you think, @bfitzexpensify ? Should we hold until I find the cause and cp the fix (probably 1-2 hours max)? Or go ahead
dangrous commentedon Jan 16, 2025
okay fix is up for review! https://github.com/Expensify/Web-Expensify/pull/45145
dangrous commentedon Jan 16, 2025
we're CP-ing it to staging and then prod, so should be pretty quick to solve this
dangrous commentedon Jan 16, 2025
this is all set!