You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-05] [$250] Reports - Pay button does not change to Review button after unselecting category #55290
Version Number: 9.0.86-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check (feature added in PR #54847) If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): Mac 15.0 / Chrome Issue reported by: Applause Internal Team Device used:applausetester+100106kh@applause.expensifail.com App Component: Search
Action Performed:
Precondition:
"Members must categorize all expenses" is enabled in Categories settings.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses with category.
Go to Reports.
Go to Outstanding.
Click View on any individual expense from Step 3.
Click Category.
Click on the selected category to unselect it.
Close the RHP.
Expected Result:
Pay button on the grouped expense should change to Review button because one of the expenses has violation.
Actual Result:
Pay button on the grouped expense does not change to Review button after unselecting the category.
It only shows Review button after refreshing the page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
@sobitneupane@stephanieelliott@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 15, 2025
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 15, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
vincdargento commentedon Jan 15, 2025
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
luacmartins commentedon Jan 15, 2025
I mentioned this case here and it's NAB. We can keep the issue open to get some proposals on how to fix this though
35 remaining items
melvin-bot commentedon Jan 29, 2025
@sobitneupane @stephanieelliott @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Feb 7, 2025
@luacmartins, @sobitneupane, @stephanieelliott, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!
luacmartins commentedon Feb 10, 2025
Just pending payment
stephanieelliott commentedon Feb 11, 2025
@sobitneupane requires payment through NewDot Manual Requests
@nkdengineer requires payment automatic offer (Contributor)
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~021889214956264201541
sobitneupane commentedon Feb 12, 2025
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Feb 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Add violations to Search actions #54847
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
stephanieelliott commentedon Feb 13, 2025
Regression test created: https://github.com/Expensify/Expensify/issues/469880
stephanieelliott commentedon Feb 13, 2025
All paid! Closing.
garrettmknight commentedon Mar 24, 2025
$250 approved for @sobitneupane