Skip to content

[HOLD for payment 2025-02-05] [$250] Reports - Pay button does not change to Review button after unselecting category #55290

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.86-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check (feature added in PR #54847)
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Search

Action Performed:

Precondition:

  • "Members must categorize all expenses" is enabled in Categories settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two expenses with category.
  4. Go to Reports.
  5. Go to Outstanding.
  6. Click View on any individual expense from Step 3.
  7. Click Category.
  8. Click on the selected category to unselect it.
  9. Close the RHP.

Expected Result:

Pay button on the grouped expense should change to Review button because one of the expenses has violation.

Actual Result:

Pay button on the grouped expense does not change to Review button after unselecting the category.

It only shows Review button after refreshing the page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021879572765790104174
  • Upwork Job ID: 1879572765790104174
  • Last Price Increase: 2025-01-15
  • Automatic offers:
    • nkdengineer | Contributor | 105775204
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 15, 2025
  2. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Jan 15, 2025

    @vincdargento
    Author

    @stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. luacmartins commented on Jan 15, 2025

    @luacmartins
    Contributor

    I mentioned this case here and it's NAB. We can keep the issue open to get some proposals on how to fix this though

  8. self-assigned this
    on Jan 15, 2025
  9. 35 remaining items

  10. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    @sobitneupane @stephanieelliott @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Feb 7, 2025

    @melvin-bot

    @luacmartins, @sobitneupane, @stephanieelliott, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. luacmartins commented on Feb 10, 2025

    @luacmartins
    Contributor

    Just pending payment

  13. stephanieelliott commented on Feb 11, 2025

    @stephanieelliott
    Contributor

    @sobitneupane requires payment through NewDot Manual Requests
    @nkdengineer requires payment automatic offer (Contributor)

    Summarizing payment on this issue:

    Upwork job is here: https://www.upwork.com/jobs/~021889214956264201541

  14. sobitneupane commented on Feb 12, 2025

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Go to workspace chat.
    2. Submit two expenses with category.
    3. Go to Reports.
    4. Go to Outstanding.
    5. Click View on any individual expense from Step 3.
    6. Click Category.
    7. Click on the selected category to unselect it.
    8. Close the RHP.
    9. Verify that: Pay button on the grouped expense changes to Review button

    Do we agree 👍 or 👎

  15. sobitneupane commented on Feb 12, 2025

    @sobitneupane
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Add violations to Search actions #54847

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

  16. stephanieelliott commented on Feb 13, 2025

    @stephanieelliott
    Contributor
  17. stephanieelliott commented on Feb 13, 2025

    @stephanieelliott
    Contributor

    All paid! Closing.

  18. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Feb 13, 2025
  19. garrettmknight commented on Mar 24, 2025

    @garrettmknight
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions