Skip to content

[Due for payment 2025-03-03] Per diem - Negative amount turns to positive amount after sorting duplicates #55404

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has per diem rates.
  • At least one subrate has negative amount.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two same per diem rates with a negative amount.
  4. Go to transaction thread of any expense in Step 3.
  5. Click Review duplicates.
  6. Click Keep this one on any expense preview.
  7. Click Confirm.

Expected Result:

The negative amount will be preserved.

Actual Result:

The negative amount turns to positive amount after sorting duplicates.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6716731_1737123255423.20250117_215351.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 17, 2025
  2. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. iwiznia commented on Jan 17, 2025

    @iwiznia
    Contributor

    Per diem is under beta, so not a blocker

  7. 28 remaining items

  8. ishpaul777 commented on Mar 3, 2025

    @ishpaul777
    Contributor

    yes i'll fill it out before requesting in ND

  9. ishpaul777 commented on Mar 3, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/42571/files#r1984081677

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. yes

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Workspace has per diem rates.
    • At least one subrate has negative amount.

    Test:

    1. Go to staging.new.expensify.com
    2. Go to workspace chat.
    3. Submit two same per diem rates with a negative amount.
    4. Go to transaction thread of any expense in Step 3.
    5. Click Review duplicates.
    6. Click Keep this one on any expense preview.
    7. Click Confirm.
    8. Expected Result: The negative amount will be preserved.

    Do we agree 👍 or 👎

  10. ishpaul777 commented on Mar 3, 2025

    @ishpaul777
    Contributor

    @shubham1206agra one checkbox for you above checklist ^ if you can help me out

  11. jliexpensify commented on Mar 5, 2025

    @jliexpensify
    Contributor

    Bumping @shubham1206agra for the checklist!

  12. shubham1206agra commented on Mar 5, 2025

    @shubham1206agra
    Contributor

    @ishpaul777 See #42571 for dupe logic. Since this bug existed before per diem, just do -ve expense to repro this on older version.

  13. jliexpensify commented on Mar 5, 2025

    @jliexpensify
    Contributor

    Can I close out this GH? :)

  14. shubham1206agra commented on Mar 6, 2025

    @shubham1206agra
    Contributor

    @ishpaul777 Bump here

  15. ishpaul777 commented on Mar 6, 2025

    @ishpaul777
    Contributor

    Done, thank you Shubham!

  16. ishpaul777 commented on Mar 6, 2025

    @ishpaul777
    Contributor

    I have requested in ND! this is good to close!

  17. garrettmknight commented on Mar 11, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

  18. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions