You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-03] Per diem - Negative amount turns to positive amount after sorting duplicates #55404
Version Number: 9.0.87-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers): Mac 15.0 / Chrome Issue reported by: Applause Internal Team Device used:applausetester+100106kh@applause.expensifail.com App Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates.
At least one subrate has negative amount.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two same per diem rates with a negative amount.
Go to transaction thread of any expense in Step 3.
Click Review duplicates.
Click Keep this one on any expense preview.
Click Confirm.
Expected Result:
The negative amount will be preserved.
Actual Result:
The negative amount turns to positive amount after sorting duplicates.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Workspace has per diem rates.
At least one subrate has negative amount.
Test:
Go to staging.new.expensify.com
Go to workspace chat.
Submit two same per diem rates with a negative amount.
Go to transaction thread of any expense in Step 3.
Click Review duplicates.
Click Keep this one on any expense preview.
Click Confirm.
Expected Result: The negative amount will be preserved.
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
iwiznia commentedon Jan 17, 2025
Per diem is under beta, so not a blocker
28 remaining items
ishpaul777 commentedon Mar 3, 2025
yes i'll fill it out before requesting in ND
ishpaul777 commentedon Mar 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/42571/files#r1984081677
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
ishpaul777 commentedon Mar 3, 2025
@shubham1206agra one checkbox for you above checklist ^ if you can help me out
jliexpensify commentedon Mar 5, 2025
Bumping @shubham1206agra for the checklist!
shubham1206agra commentedon Mar 5, 2025
@ishpaul777 See #42571 for dupe logic. Since this bug existed before per diem, just do -ve expense to repro this on older version.
jliexpensify commentedon Mar 5, 2025
Can I close out this GH? :)
shubham1206agra commentedon Mar 6, 2025
@ishpaul777 Bump here
ishpaul777 commentedon Mar 6, 2025
Done, thank you Shubham!
ishpaul777 commentedon Mar 6, 2025
I have requested in ND! this is good to close!
garrettmknight commentedon Mar 11, 2025
$250 approved for @ishpaul777
garrettmknight commentedon Apr 22, 2025
$250 approved for @shubham1206agra