Skip to content

Update report next steps copy #55471

Closed
Closed

Description

@jamesdeanexpensify

Background

Coming from this conversation, there are some incorrect next steps showing on reports. We need to fix that.

Details

The two updates below should be made to both NewDot and OldDot:

  • The next steps on an empty report should read Waiting for <user> to add expense(s).
  • The next steps on an open report with scheduled/delayed submit set to manual should read Waiting for <user> to submit expense(s).

Screenshot

Here's an example of where the next steps are incorrect in NewDot currently:

Image

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 20, 2025
  2. melvin-bot commented on Jan 20, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Jan 20, 2025

    @mkzie2
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 05:50:49 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • The next steps on an empty report should read Waiting for to add expense(s).
    • The next steps on an open report with scheduled/delayed submit set to manual should read Waiting for to submit expense(s).

    What is the root cause of that problem?

    Feature update

    What changes do you think we should make in order to solve the problem?

    For this case:

    case CONST.REPORT.STATUS_NUM.OPEN:
    // Self review
    optimisticNextStep = {

    1. The empty report has been handled by default.

    2. Add a condition for open report with scheduled/delayed submit set to manual:

    !harvesting?.enabled && autoReportingFrequency === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE

    And modify optimisticNextStep.message to Waiting for <user> to submit expense(s).

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    Update the NextStepUtilsTest for the default (the (1)) case here and the manual submit case here

  4. moved this to First Cohort - MEDIUM or LOW in [#whatsnext] #migrateon Jan 21, 2025
  5. added
    Hot PickReady for an engineer to pick up and run with
    on Jan 21, 2025
  6. self-assigned this
    on Jan 21, 2025
  7. added
    ReviewingHas a PR in review
    and removed
    Hot PickReady for an engineer to pick up and run with
    on Jan 21, 2025
  8. dangrous commented on Jan 22, 2025

    @dangrous
    Contributor

    we actually need two more PRs for this - we need to make one change in Mobile-Expensify to match the old dot side, and then we need to update the optimistic stuff and tests in App. Will get those up shortly.

  9. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions