You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we actually need two more PRs for this - we need to make one change in Mobile-Expensify to match the old dot side, and then we need to update the optimistic stuff and tests in App. Will get those up shortly.
Activity
melvin-bot commentedon Jan 20, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Jan 20, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 05:50:49 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Feature update
What changes do you think we should make in order to solve the problem?
For this case:
App/src/libs/NextStepUtils.ts
Lines 112 to 114 in 177dd5e
The
empty reporthas been handled by default.Add a condition for
open report with scheduled/delayed submit set to manual:And modify
optimisticNextStep.messagetoWaiting for <user> to submit expense(s).What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
Update the
NextStepUtilsTestfor the default (the (1)) case here and themanualsubmit case heredangrous commentedon Jan 22, 2025
we actually need two more PRs for this - we need to make one change in Mobile-Expensify to match the old dot side, and then we need to update the optimistic stuff and tests in App. Will get those up shortly.