You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-05] [$250] "you've been switched to focus mode" modal after open an expense on the Reports page #55492
Version Number: Reproducible in staging?: need reproduction Reproducible in production?: need reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@puneetlath Slack conversation (hyperlinked to channel name): retain
Action Performed:
Login to an account
Have several messages received by other users
Open an expense on the report page
Expected Result:
"you've been switched to focus mode" modal should only show this on the Inbox.
Actual Result:
"you've been switched to focus mode" modal appears after open an expense on the Reports page.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]"you've been switched to focus mode" modal after open an expense on the Reports page[/-][+][$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/+]on Jan 21, 2025
changed the title [-][$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/-][+][HOLD for payment 2025-02-05] [$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/+]on Jan 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@dylanexpensify@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: It's the edge case so I think no need to comment on the offending PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in https://app.slack.com/client/E047TPA624F/C01GTK53T8Q has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Activity
melvin-bot commentedon Jan 21, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.truph01 commentedon Jan 21, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-01-22 09:52:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/Expensify.tsx
Line 273 in bec182c
so it will be shown as long as
FocusModeNotificationistrue:App/src/Expensify.tsx
Line 96 in bec182c
What changes do you think we should make in order to solve the problem?
App/src/Expensify.tsx
Line 273 in bec182c
and use it in here:
shouldShowFocusModeNotification:tryToTriggerFocusModeModalwhen these two events appear:When user navigate to Inbox or Report page.
When user already are in the inbox or Report page but the
focusModeNotificationis updated.With the 1st event, we can call it in here.
With the 2nd event, we can call it in useEffect:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Alternative solution 1:
App/src/Expensify.tsx
Line 273 in bec182c
and use it in here:
shouldShowFocusModeNotification:tryToTriggerFocusModeModalwhen these two events appear:When user navigate to Inbox or Report page.
When user already are in the inbox or Report page but the
focusModeNotificationis updated.With the 1st event, we can call it in here:
With the 2nd event, we can call it in useEffect:
Alternative solution 2:
dylanexpensify commentedon Jan 21, 2025
Nice one, reviewing today!
[-]"you've been switched to focus mode" modal after open an expense on the Reports page[/-][+][$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/+]melvin-bot commentedon Jan 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021881627889773961977
melvin-bot commentedon Jan 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)dukenv0307 commentedon Jan 22, 2025
@truph01 Thanks for your proposal. I like your idea, but can we somehow add
currentRoutecheck intryFocusModeUpdatethen trigger
tryFocusModeUpdatewhenever navigation status changes? I think movingFocusModeNotificationto NavigationRoot is not a best practise.15 remaining items
[-][$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/-][+][HOLD for payment 2025-02-05] [$250] "you've been switched to focus mode" modal after open an expense on the Reports page[/+]melvin-bot commentedon Jan 29, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 29, 2025
@dukenv0307 @dylanexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon Jan 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: It's the edge case so I think no need to comment on the offending PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in https://app.slack.com/client/E047TPA624F/C01GTK53T8Q has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
The nvp_priorityMode setting is set to false.
There are fewer than 30 reports.
The user is in default mode.
Navigate to the "Reports" tab.
Do we agree 👍 or 👎
dylanexpensify commentedon Feb 5, 2025
Payment summary:
Contributor: @truph01 $250 via Upwork
Contributor+: @dukenv0307 $250 via NewDot
Please apply/request!
dylanexpensify commentedon Feb 5, 2025
Done
JmillsExpensify commentedon Feb 20, 2025
$250 approved for @dukenv0307