Skip to content

[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-30] [$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding #55553

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.88-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod

If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): Samsung Galaxy Z Fold 4 / Android 14
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Workspace Settings

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to Account settings > Workspaces.
  3. Tap New workspace.
  4. Tap Currency.
  5. Compare the bottom padding of the currency list with the currency list in Workspace profile.

Expected Result:

The currency list in create workspace page will not have extra bottom padding.

Actual Result:

The currency list in create workspace page has extra bottom padding.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/3bdfa365-6346-4df0-b59d-c724d3ca0cae
Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021881843964646572722
  • Upwork Job ID: 1881843964646572722
  • Last Price Increase: 2025-01-21
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 21, 2025
  2. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. allgandalf commented on Jan 21, 2025

    @allgandalf
    Contributor
  7. Krishna2323 commented on Jan 21, 2025

    @Krishna2323
    Contributor

    @allgandalf, are you able to reproduce this issue?

  8. 19 remaining items

  9. changed the title [-][$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding[/-] [+][HOLD for payment 2025-01-30] [$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding[/+] on Jan 23, 2025
  10. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
  11. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    @Pujan92 @CortneyOfstad @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. changed the title [-][HOLD for payment 2025-01-30] [$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding[/-] [+][HOLD for payment 2025-02-04] [HOLD for payment 2025-01-30] [$250] Android/iOS - Workspace - Currency list in new workspace page has extra bottom padding[/+] on Jan 28, 2025
  13. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    @Pujan92 @CortneyOfstad @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. marcochavezf commented on Jan 31, 2025

    @marcochavezf
    Contributor

    We're handling the payment for C+ review here, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions