Skip to content

[Due for payment 2025-02-05] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly #55601

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.88-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53845
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Apple iPhone 12 Pro / Safari
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a Gmail account that already has a workspace
  3. Navigate to Settings - Workspaces
  4. Tap on the "New workspace" button
  5. Tap on "Default currency" and quickly swipe up

Expected Result:

Currency selector should scroll down.

Actual Result:

Currency selector scrolls to the top when I scroll down quickly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6719916_1737467985381.RTSM3943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882074796298844828
  • Upwork Job ID: 1882074796298844828
  • Last Price Increase: 2025-01-22
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 105822350
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 22, 2025
  2. melvin-bot commented on Jan 22, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 22, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. allgandalf commented on Jan 22, 2025

    @allgandalf
    Contributor

    @Krishna2323 will fix this one too as part of #55575

  7. Beamanator commented on Jan 22, 2025

    @Beamanator
    Contributor
  8. 50 remaining items

  9. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-05. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    @ZhenjaHorbach @RachCHopkins @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][HOLD for payment 2025-02-05] [Due for payment 2025-02-04] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly[/-] [+][Due for payment 2025-02-05] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly[/+] on Jan 29, 2025
  12. RachCHopkins commented on Feb 3, 2025

    @RachCHopkins
    Contributor

    @ZhenjaHorbach do you mind doing the checklist, please?

  13. ZhenjaHorbach commented on Feb 4, 2025

    @ZhenjaHorbach
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/39201/files#r1940663083

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Test:

    1. Open Settings > Workspace > New workspace
    2. Press the currency field
    3. Quickly scrolls down when the page opens
    4. Verify the page doesn't scroll to the top

    Do we agree 👍 or 👎

  14. melvin-bot commented on Feb 5, 2025

    @melvin-bot

    @carlosmiceli @RachCHopkins @bernhardoj @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  15. RachCHopkins commented on Feb 5, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @bernhardoj to be paid $250 via NewDot manual requests
    • Contributor+: @ZhenjaHorbach to be paid $250 via Upwork

    Upwork job here

  16. bernhardoj commented on Feb 6, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  17. RachCHopkins commented on Feb 8, 2025

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  18. JmillsExpensify commented on Feb 10, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions