Skip to content

[HOLD for payment 2025-02-05] [$250] Remove Split Expense from trip rooms #55665

Closed

Description

@stitesExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C05S5EV2JTX/p1737648185018489

Action Performed:

  1. Create a new booking in Expensify Travel
  2. Go to the trip room in NewDot
  3. Click the plus

Expected Result:

"Split Expense" should not be shown

Actual Result:

"Split Expense" is shown

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882514602052857567
  • Upwork Job ID: 1882514602052857567
  • Last Price Increase: 2025-01-23
  • Automatic offers:
    • shubham1206agra | Contributor | 105829489
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 23, 2025
  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot
  3. changed the title [-]Remove Split Expense from trip rooms[/-] [+][$250] Remove Split Expense from trip rooms[/+] on Jan 23, 2025
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 23, 2025
  5. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  7. stitesExpensify commented on Jan 23, 2025

    @stitesExpensify
    ContributorAuthor

    Removing @jayeshmangwani because @blazejkustra and @shubham1206agra are handling this per the slack thread

  8. shubham1206agra commented on Jan 23, 2025

    @shubham1206agra
    Contributor

    👋🏽

  9. daledah commented on Jan 23, 2025

    @daledah
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-01-23 19:58:44 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Split Expense" is shown

    What is the root cause of that problem?

    We always show split expense here

    [CONST.IOU.TYPE.SPLIT]: {
    icon: Expensicons.Transfer,
    text: translate('iou.splitExpense'),
    onSelected: () => selectOption(() => startMoneyRequest(CONST.IOU.TYPE.SPLIT, report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)), true),
    },

    What changes do you think we should make in order to solve the problem?

    In this condition we will not show CONST.IOU.TYPE.SPLIT when this report is not a trip room by using ReportUtils.isTripRoom(report)

    App/src/libs/ReportUtils.ts

    Lines 7328 to 7335 in 9aaed6d

    if (
    (isChatRoom(report) && !isAnnounceRoom(report) && otherParticipants.length > 0) ||
    (isDM(report) && otherParticipants.length > 0) ||
    (isGroupChat(report) && otherParticipants.length > 0) ||
    (isPolicyExpenseChat(report) && report?.isOwnPolicyExpenseChat)
    ) {
    options = [CONST.IOU.TYPE.SPLIT];
    }

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  10. 15 remaining items

  11. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    @shubham1206agra @kadiealexander @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. kadiealexander commented on Feb 5, 2025

    @kadiealexander
    Contributor

    Payments due:

    Upwork job

    @shubham1206agra please complete the checklist.

  13. kadiealexander commented on Feb 7, 2025

    @kadiealexander
    Contributor

    I'm going OOO next week, reassigning for someone to issue payment when the checklist is complete.

  14. stitesExpensify commented on Feb 10, 2025

    @stitesExpensify
    ContributorAuthor

    @shubham1206agra can you do the checklist so that we can pay this out?

  15. melvin-bot commented on Feb 11, 2025

    @melvin-bot

    @CortneyOfstad, @stitesExpensify, @blazejkustra, @shubham1206agra, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. shubham1206agra commented on Feb 11, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA since this was an UX change which was decided later

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Create a new booking in Expensify Travel
    2. Go to the trip room in NewDot
    3. Click the plus
    4. Verify that no Split expense option is shown in the menu.

    Do we agree 👍 or 👎

  17. CortneyOfstad commented on Feb 11, 2025

    @CortneyOfstad
    Contributor

    @shubham1206agra it looks like contract in Upwork is pending — can you accept that ASAP? Once that is done, let me know and I'll get this paid right away.

    Thanks!

  18. shubham1206agra commented on Feb 11, 2025

    @shubham1206agra
    Contributor

    @CortneyOfstad Offer accepted

  19. CortneyOfstad commented on Feb 12, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @shubham1206agra — paid $250 via Upwork
    @blazejkustra — outside contractor

    Regression Test

    https://github.com/Expensify/Expensify/issues/469774

    Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions