Skip to content

[$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown #55670

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
**Email or phone of affected tester (no customers):**https://expensify.testrail.io/index.php?/cases/view/2990420
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to ND: https://staging.new.expensify.com/
  2. Sign up with a new account (close the window when the onboarding modal is shown)
  3. Go to OD: https://staging.expensify.com/
  4. Sign in with the previous account
  5. Open Android Hybrid app
  6. Sign in with the same account
  7. Tap on 'Manage my team's expenses' > '11-50 employees'
  8. Tap on 'Continue'

Expected Result:

After tapping on continue, the user is re-directed to the "Do you use any accounting software?" modal

Actual Result:

After tapping on continue, the user is re-directed to OD

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
screen-20250123-215350.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883954079218001795
  • Upwork Job ID: 1883954079218001795
  • Last Price Increase: 2025-02-17
Issue OwnerCurrent Issue Owner: @c3024

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 23, 2025
  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 27, 2025

    @melvin-bot

    @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. zanyrenney commented on Jan 27, 2025

    @zanyrenney
    Contributor

    oh no! this is great for the onboarding journey, we need to resolve this ASAP.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 27, 2025
  6. changed the title [-]Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/-] [+][$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/+] on Jan 27, 2025
  7. melvin-bot commented on Jan 27, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 27, 2025
  9. zanyrenney commented on Jan 27, 2025

    @zanyrenney
    Contributor

    added external label.

  10. melvin-bot commented on Jan 27, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  11. 32 remaining items

  12. VickyStash commented on Feb 17, 2025

    @VickyStash
    Contributor

    UPD:
    I continue my investigations:

    • After the user closes the tab with the onboarding modal in the ND and login with the same account to the OD, API returns the Your session has expired error right after login.
    Image
    • Then, after login to Hybrid App and passing through the onboarding steps the tryNewDot.classicRedirect.dismissed flag is turned into true by the hybrid app setTryNewDot function. Turning the flag into true makes the user not be redirected to the new dot. I'm working on a fix.
  13. VickyStash commented on Feb 17, 2025

    @VickyStash
    Contributor

    @lanitochka17 @zanyrenney I did some research, and it looks like this is not an issue, but expected behavior introduced in this PR for this issue 🤔
    Since in current issue test steps the step 7 is Tap on 'Manage my team's expenses' > '11-50 employees' it's expected the user is re-directed to OD.
    cc @mateuuszzzzz @trjExpensify since they are working on the related issue.

  14. trjExpensify commented on Feb 17, 2025

    @trjExpensify
    Contributor

    Finding it a littttle bit difficult to parse the steps from the OP. 😅

    But yes, we're working on sending native sign-ups on HybridApp or new.expensify.com back to OldDot if they select the 11+ options in the employee count step of the onboarding modal.

    What's going on with the session expired stuff though?

  15. VickyStash commented on Feb 18, 2025

    @VickyStash
    Contributor

    What's going on with the session expired stuff though?

    @trjExpensify It's not described in this issue, just something I have noticed during the testing:

    Pre-steps:
    Use one browser window and make sure you’re signed-out of any account on new.expensify.com and expensify.com prior to starting the steps below.

    Steps:

    1. Login with new account in the ND.
    2. Close the window when the onboarding modal is shown.
    3. Open the OD and login with the account from step 1.
    4. User is navigated to the ND, but logged out right after that. All requests failed with Your session has expired error.

    Video:

    video_bug.mp4

    I can investigate it, just let me know if I should do it inside this issue or if a separate one should be created.

  16. trjExpensify commented on Feb 18, 2025

    @trjExpensify
    Contributor

    Got it, I think a new issue for that and close this one if it's the only real bug here. Though @mountiny, didn't this get worked on recently? 🤔

  17. mountiny commented on Feb 19, 2025

    @mountiny
    Contributor

    I dont think it was the exact steps, but I agree we could look into it. It was @koko57 debugging the flows with multiple tabs.

    @VickyStash I think you can create issues, can you please create new one with these details and then we can close this

  18. koko57 commented on Feb 19, 2025

    @koko57
    Contributor

    my case looked different, but I wouldn't be surprised if they had the same / similar root cause. Ofc I'm ready to help

  19. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    @zanyrenney, @c3024 10 days overdue. I'm getting more depressed than Marvin.

  20. VickyStash commented on Feb 19, 2025

    @VickyStash
    Contributor

    @mountiny I've opened the issue and commented for the assignment!

  21. mountiny commented on Feb 19, 2025

    @mountiny
    Contributor

    Perfect, thanks!

  22. kavimuru commented on Feb 25, 2025

    @kavimuru
  23. isagoico commented on Feb 26, 2025

    @isagoico

    We reviewed this issue and based on the redirection changes we need to update the TC associated with this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions