You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown #55670
Version Number: 9.0.89-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail:
**Email or phone of affected tester (no customers):**https://expensify.testrail.io/index.php?/cases/view/2990420 Issue reported by: Applause - Internal Team
changed the title [-]Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/-][+][$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/+]on Jan 27, 2025
After the user closes the tab with the onboarding modal in the ND and login with the same account to the OD, API returns the Your session has expired error right after login.
Then, after login to Hybrid App and passing through the onboarding steps the tryNewDot.classicRedirect.dismissed flag is turned into true by the hybrid app setTryNewDot function. Turning the flag into true makes the user not be redirected to the new dot. I'm working on a fix.
@lanitochka17@zanyrenney I did some research, and it looks like this is not an issue, but expected behavior introduced in this PR for this issue 🤔
Since in current issue test steps the step 7 is Tap on 'Manage my team's expenses' > '11-50 employees' it's expected the user is re-directed to OD.
cc @mateuuszzzzz@trjExpensify since they are working on the related issue.
Finding it a littttle bit difficult to parse the steps from the OP. 😅
But yes, we're working on sending native sign-ups on HybridApp or new.expensify.com back to OldDot if they select the 11+ options in the employee count step of the onboarding modal.
What's going on with the session expired stuff though?
What's going on with the session expired stuff though?
@trjExpensify It's not described in this issue, just something I have noticed during the testing:
Pre-steps:
Use one browser window and make sure you’re signed-out of any account on new.expensify.com and expensify.com prior to starting the steps below.
Steps:
Login with new account in the ND.
Close the window when the onboarding modal is shown.
Open the OD and login with the account from step 1.
User is navigated to the ND, but logged out right after that. All requests failed with Your session has expired error.
Video:
video_bug.mp4
I can investigate it, just let me know if I should do it inside this issue or if a separate one should be created.
Activity
melvin-bot commentedon Jan 23, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 27, 2025
@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
zanyrenney commentedon Jan 27, 2025
oh no! this is great for the onboarding journey, we need to resolve this ASAP.
[-]Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/-][+][$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown[/+]melvin-bot commentedon Jan 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021883954079218001795
zanyrenney commentedon Jan 27, 2025
added external label.
melvin-bot commentedon Jan 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)32 remaining items
VickyStash commentedon Feb 17, 2025
UPD:
I continue my investigations:
Your session has expired errorright after login.tryNewDot.classicRedirect.dismissedflag is turned into true by the hybrid app setTryNewDot function. Turning the flag into true makes the user not be redirected to the new dot. I'm working on a fix.VickyStash commentedon Feb 17, 2025
@lanitochka17 @zanyrenney I did some research, and it looks like this is not an issue, but expected behavior introduced in this PR for this issue 🤔
Since in current issue test steps the step 7 is
Tap on 'Manage my team's expenses' > '11-50 employees'it's expected the user is re-directed to OD.cc @mateuuszzzzz @trjExpensify since they are working on the related issue.
trjExpensify commentedon Feb 17, 2025
Finding it a littttle bit difficult to parse the steps from the OP. 😅
But yes, we're working on sending native sign-ups on HybridApp or new.expensify.com back to OldDot if they select the 11+ options in the employee count step of the onboarding modal.
What's going on with the session expired stuff though?
VickyStash commentedon Feb 18, 2025
@trjExpensify It's not described in this issue, just something I have noticed during the testing:
Pre-steps:
Use one browser window and make sure you’re signed-out of any account on new.expensify.com and expensify.com prior to starting the steps below.
Steps:
Your session has expired error.Video:
video_bug.mp4
I can investigate it, just let me know if I should do it inside this issue or if a separate one should be created.
trjExpensify commentedon Feb 18, 2025
Got it, I think a new issue for that and close this one if it's the only real bug here. Though @mountiny, didn't this get worked on recently? 🤔
mountiny commentedon Feb 19, 2025
I dont think it was the exact steps, but I agree we could look into it. It was @koko57 debugging the flows with multiple tabs.
@VickyStash I think you can create issues, can you please create new one with these details and then we can close this
koko57 commentedon Feb 19, 2025
my case looked different, but I wouldn't be surprised if they had the same / similar root cause. Ofc I'm ready to help
melvin-bot commentedon Feb 19, 2025
@zanyrenney, @c3024 10 days overdue. I'm getting more depressed than Marvin.
VickyStash commentedon Feb 19, 2025
@mountiny I've opened the issue and commented for the assignment!
mountiny commentedon Feb 19, 2025
Perfect, thanks!
kavimuru commentedon Feb 25, 2025
isagoico commentedon Feb 26, 2025
We reviewed this issue and based on the redirection changes we need to update the TC associated with this test.