Skip to content

Invoices - Bank account row is missing currency after reset and restart app #55674

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: No, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+230102kh@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Invoices
  3. Click Add bank account
  4. Select any non-US country (eg, India)
  5. Go through the setup to add an India bank account
  6. Note that it shows INR before the dot separator in the bank account row
  7. Go to account settings > Troubleshoot > Clear cache and restart
  8. Click Reset and restart
  9. Do not go to Wallet
  10. Go to workspace settings > Invoices
  11. Note that the bank account row is missing currency before the dot separator
  12. Go to account settings > Wallet
  13. Go back to workspace settings > Invoices
  14. Now it shows INR before the dot separator in the bank account row

Expected Result:

In Step 11, the bank account row should show the currency after reset and restart the app

Actual Result:

In Step 11, the bank account row is missing currency after reset and restart the app.
The currency only appears after opening Wallet page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6722176_1737666816318.20250124_050434.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jan 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jan 23, 2025

    @lanitochka17
    Author

    A new feature (different behavior on prod)

    bandicam.2025-01-24.00-28-40-328.mp4
  5. mkzie2 commented on Jan 24, 2025

    @mkzie2
    Contributor

    OpenApp API is missing bankCurrency in bankAccountList:

    Image

    This also happens when you sign out and sign in again.

    However, we can apply an improvement in the FE to only show the currency (and the dot separator) when it exists as mentioned in my proposal here #55675 (comment).

  6. Beamanator commented on Jan 24, 2025

    @Beamanator
    Contributor

    @MonilBhavsar @shubham1206agra @DylanDylann is this NAB b/c of the same beta as #55672 (comment)?

  7. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    Contributor

    @Beamanator This is a BE bug. Can you mark this internal?

  8. Beamanator commented on Jan 24, 2025

    @Beamanator
    Contributor

    Okkk @shubham1206agra can you explain a bit more why you say so? I may be able to help fix if i know the prob :D

  9. shubham1206agra commented on Jan 24, 2025

    @shubham1206agra
    Contributor

    @Beamanator See #55674 (comment) for explanation.

  10. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 24, 2025
  11. Beamanator commented on Jan 24, 2025

    @Beamanator
    Contributor

    Shmart!

  12. Beamanator commented on Jan 24, 2025

    @Beamanator
    Contributor

    Looks like @MonilBhavsar worked that in the backend recently, maybe you want to take this over

  13. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 24, 2025
  14. MonilBhavsar commented on Jan 24, 2025

    @MonilBhavsar
    Contributor

    Yep, feature is under beta and looks backend. I'll take over

  15. MonilBhavsar commented on Jan 28, 2025

    @MonilBhavsar
    Contributor

    Sent a PR

  16. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. MonilBhavsar commented on Feb 4, 2025

    @MonilBhavsar
    Contributor

    PR was deployed. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions