You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-05] [$250] Room - Room mention turns into a random number after leaving a private room #55676
Version Number: 9.0.89-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):nathanmulugetatesting+2850@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Navigate to staging.new.expensify.com
Create a workspace
Create a private room
Go to the workspace chat and mention the room
Navigate to the room by tapping on the room mention
Leave from the private room
Expected Result:
The room mention stays displaying the room name
Actual Result:
The room mention changes to show a random number
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6722182_1737667139938.XRecorder_24012025_001119.mp4
changed the title [-]Room - Room mention turns into a random number after leaving a private room[/-][+][$250] Room - Room mention turns into a random number after leaving a private room[/+]on Jan 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@paultsimura@abekkala@paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, this case was not covered before.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 23, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jan 23, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-01-23 23:06:35 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The room mention changes to show a random number
What is the root cause of that problem?
When leaving room, we set the
reportNametonull:App/src/libs/actions/Report.ts
Lines 3106 to 3107 in d930fea
so we display the
reportID:App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 37 in d930fea
What changes do you think we should make in order to solve the problem?
We shouldn't set the
reportNameto null in:App/src/libs/actions/Report.ts
Line 3107 in d930fea
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We should mock the room data and then simulate the leaving room action. Then verify whether its name still exists.
What alternative solutions did you explore? (Optional)
In:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 37 in d930fea
pass the
reportActiondata:In:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 59 in d930fea
we get the
reportActiondata.In:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 70 in d930fea
pass the
reportActionas the 5th param.In:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 29 in d930fea
update the function so that it can receive 5th param.
Finally, update:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 37 in d930fea
melvin-bot commentedon Jan 27, 2025
@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jan 29, 2025
@abekkala Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Jan 31, 2025
@abekkala 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
[-]Room - Room mention turns into a random number after leaving a private room[/-][+][$250] Room - Room mention turns into a random number after leaving a private room[/+]melvin-bot commentedon Jan 31, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021885423124058262616
melvin-bot commentedon Jan 31, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (
External)48 remaining items
melvin-bot commentedon Feb 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 26, 2025
@paultsimura @abekkala @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Feb 28, 2025
PAYMENT SUMMARY FOR MAR 05
please complete checklist
abekkala commentedon Mar 5, 2025
@paultsimura please complete checklist and I can submit payment and close this out today. Thanks!
paultsimura commentedon Mar 5, 2025
Thanks @abekkala, filling it out now!
abekkala commentedon Mar 5, 2025
@daledah Payment sent and Contract ended - thank you! 🎉
paultsimura commentedon Mar 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, this case was not covered before.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/477950
Regression Test Proposal
Precondition:
The user is a Workspace owner
Test:
Do we agree 👍 or 👎
paultsimura commentedon Mar 5, 2025
Done @abekkala
abekkala commentedon Mar 6, 2025
@paultsimura payment sent and contract ended - thank you! 🎉