Skip to content

[Due for payment 2025-03-05] [$250] Room - Room mention turns into a random number after leaving a private room #55676

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+2850@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace
  3. Create a private room
  4. Go to the workspace chat and mention the room
  5. Navigate to the room by tapping on the room mention
  6. Leave from the private room

Expected Result:

The room mention stays displaying the room name

Actual Result:

The room mention changes to show a random number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6722182_1737667139938.XRecorder_24012025_001119.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021885423124058262616
  • Upwork Job ID: 1885423124058262616
  • Last Price Increase: 2025-02-14
  • Automatic offers:
    • paultsimura | Reviewer | 106196319
    • daledah | Contributor | 106196323
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 23, 2025
  2. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Jan 23, 2025

    @daledah
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-01-23 23:06:35 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The room mention changes to show a random number

    What is the root cause of that problem?

    When leaving room, we set the reportName to null:

    App/src/libs/actions/Report.ts

    Lines 3106 to 3107 in d930fea

    : Object.keys(report).reduce<Record<string, null>>((acc, key) => {
    acc[key] = null;

    so we display the reportID:

    mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

    What changes do you think we should make in order to solve the problem?

    We shouldn't set the reportName to null in:

    acc[key] = null;

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We should mock the room data and then simulate the leaving room action. Then verify whether its name still exists.

    What alternative solutions did you explore? (Optional)

    In:

    mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

    pass the reportAction data:

        const mentionReportContextValue = useMemo(() => ({currentReportID: report?.reportID ?? '-1', reportAction: action}), [report?.reportID, action]);

    In:

    const {currentReportID: currentReportIDContext, exactlyMatch} = useContext(MentionReportContext);

    we get the reportAction data.

    In:

    const mentionDetails = getMentionDetails(htmlAttributeReportID, currentReport, reports, tnode);

    pass the reportAction as the 5th param.

    In:

    const getMentionDetails = (htmlAttributeReportID: string, currentReport: OnyxEntry<Report>, reports: OnyxCollection<Report>, tnode: TText | TPhrasing) => {

    update the function so that it can receive 5th param.

    Finally, update:

    mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

            mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? getReportActionMessageText(reportAction) ?? htmlAttributeReportID);
  4. melvin-bot commented on Jan 27, 2025

    @melvin-bot

    @abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Jan 29, 2025

    @melvin-bot

    @abekkala Eep! 4 days overdue now. Issues have feelings too...

  6. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    @abekkala 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 31, 2025
  8. changed the title [-]Room - Room mention turns into a random number after leaving a private room[/-] [+][$250] Room - Room mention turns into a random number after leaving a private room[/+] on Jan 31, 2025
  9. melvin-bot commented on Jan 31, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 31, 2025
  11. melvin-bot commented on Jan 31, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

  12. 48 remaining items

  13. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-05. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    @paultsimura @abekkala @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. abekkala commented on Feb 28, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR MAR 05

  16. abekkala commented on Mar 5, 2025

    @abekkala
    Contributor

    @paultsimura please complete checklist and I can submit payment and close this out today. Thanks!

  17. paultsimura commented on Mar 5, 2025

    @paultsimura
    Contributor

    Thanks @abekkala, filling it out now!

  18. abekkala commented on Mar 5, 2025

    @abekkala
    Contributor

    @daledah Payment sent and Contract ended - thank you! 🎉

  19. paultsimura commented on Mar 5, 2025

    @paultsimura
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A, this case was not covered before.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/477950

    Regression Test Proposal

    Precondition:

    The user is a Workspace owner

    Test:

    1. Create a private room
    2. Go to the workspace chat and mention the room
    3. Navigate to the room by tapping the room mention
    4. Leave the private room
    5. Navigate back to WS chat
    6. Verify that the room name mention is not changed

    Do we agree 👍 or 👎

  20. paultsimura commented on Mar 5, 2025

    @paultsimura
    Contributor
  21. abekkala commented on Mar 6, 2025

    @abekkala
    Contributor

    @paultsimura payment sent and contract ended - thank you! 🎉

  22. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions