Skip to content

Deleted comments can be seen in the HTML code #5571

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to a conversation
  2. Send a message
  3. Edit the message and delete all of the content
  4. Navigate to console tools > Network

Expected Result:

Deleted comment should not be accessible by the user in any part of the code.

Actual Result:

Deleted comment can be seen in the HTML code.

Workaround:

Not sure if this needs a workaround.

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.2-5

Reproducible in staging?: yes
Reproducible in production?: yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

htmlcode.mp4

Expensify/Expensify Issue URL:

Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1632613507072000

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Sep 28, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. isagoico commented on Sep 28, 2021

    @isagoico
    Author

    Please check the thread here https://expensify.slack.com/archives/C01GTK53T8Q/p1632613507072000 it has more context on the issue

  3. NikkiWines commented on Sep 29, 2021

    @NikkiWines
    Contributor

    Looks good for UpWork 👍 applying External label

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 29, 2021
  5. MelvinBot commented on Sep 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. removed their assignment
    on Sep 29, 2021
  7. akshayasalvi commented on Sep 29, 2021

    @akshayasalvi
    Contributor

    @NikkiWines This issue might have to be fixed from the backend. So contributors can work on the backend repo also ?

  8. NikkiWines commented on Sep 29, 2021

    @NikkiWines
    Contributor

    oops, yes you're right @akshayasalvi, I misread the slack thread and though we could implement your suggestions here but it does seem like this'll be backend work which contributors do not have access to.

  9. 23 remaining items

  10. NikkiWines commented on Nov 15, 2021

    @NikkiWines
    Contributor

    Oh oops, the fix for this has been on prod for roughly 2 weeks now. Closing!

  11. akshayasalvi commented on Nov 16, 2021

    @akshayasalvi
    Contributor

    @NikkiWines @mallenexpensify There'll be a payment for reporting this?

  12. mallenexpensify commented on Nov 16, 2021

    @mallenexpensify
    Contributor

    @akshayasalvi Thanks for the ping. Can you apply here please? And confirm in a comment here when you do?
    https://www.upwork.com/jobs/~01a9a9596e5085e734

  13. akshayasalvi commented on Nov 18, 2021

    @akshayasalvi
    Contributor
  14. MelvinBot commented on Nov 18, 2021

    @MelvinBot
    Contributor

    📣 @akshayasalvi You have been assigned to this job by @mallenexpensify!
    Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  15. mallenexpensify commented on Nov 18, 2021

    @mallenexpensify
    Contributor

    Hired @akshayasalvi in Upwork, can you confirm here once the offer had been accepted and I'll pay?

  16. akshayasalvi commented on Nov 19, 2021

    @akshayasalvi
    Contributor

    Accepted :)

  17. mallenexpensify commented on Nov 19, 2021

    @mallenexpensify
    Contributor

    Paid! Thanks @akshayasalvi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions