Skip to content

[HOLD for payment 2025-02-05] Payment issue for E/App PR#55487 #55722

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #55487
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/458292.
Contributor+ member who reviewed the PR - @rushatgabhane.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 24, 2025
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 24, 2025
  3. melvin-bot commented on Jan 24, 2025

    @melvin-bot
    Author

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 28, 2025

    @melvin-bot
    Author

    @anmurali, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. anmurali commented on Jan 29, 2025

    @anmurali

    Not yet on production, not overdue.

  6. 9 remaining items

  7. melvin-bot commented on Feb 3, 2025

    @melvin-bot
    Author

    @anmurali, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. anmurali commented on Feb 4, 2025

    @anmurali

    Payment not overdue. @rushatgabhane can we add a regression test meanwhile.

  9. melvin-bot commented on Feb 5, 2025

    @melvin-bot
    Author

    Payment Summary

    Upwork Job

    BugZero Checklist (@anmurali)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. rushatgabhane commented on Feb 6, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Missed in initial implementation.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    This is not testable by QA I think. So NO QA steps needed. But if you feel otherwise:

    1. Login to account A.
    2. Inspect elements -> Application -> cookies
    3. See the FS_UID cookie
    4. Logout
    5. Verify that the cookie has been cleared
    6. Login to account B.
    7. Verify that the FS_UID is different.

    Do we agree 👍 or 👎

  11. melvin-bot commented on Feb 10, 2025

    @melvin-bot
    Author

    @anmurali, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

  12. garrettmknight commented on Feb 11, 2025

    @garrettmknight
    Contributor

    @anmurali can you confirm the payment summary?

  13. melvin-bot commented on Feb 12, 2025

    @melvin-bot
    Author

    @anmurali, @rushatgabhane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. mallenexpensify commented on Feb 14, 2025

    @mallenexpensify
    Contributor

    Contributor+: @rushatgabhane due $250 via NewDot

    No Test case needed

    This is not testable by QA I think. So NO QA steps needed. But if you feel otherwise:

  15. garrettmknight commented on Feb 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions