Skip to content

[Due for payment 2025-03-21] [CRITICAL][Search] Unable to discover new rooms via Search #56583

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): Quality

Action Performed:

  1. Open the chat application within the workspace.
  2. Use the search function to look for "Hackathon room".
  3. Observe the search results.

Expected Result:

The Hackathon room should appear in the search results since it exists within the same workspace.

Actual Result:

No results are displayed when searching for Hackathon room, The room is not found despite being a part of the same workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Feb 8, 2025
  2. melvin-bot commented on Feb 8, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 8, 2025

    @melvin-bot

    Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

  4. MelvinBot commented on Feb 8, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  5. JmillsExpensify commented on Feb 8, 2025

    @JmillsExpensify
    Contributor

    For the reproduction steps, it's important to note that I'm not a member of this room, so I want to find it and join it, but it never shows up in Search.

  6. muttmuure commented on Feb 8, 2025

    @muttmuure
    Contributor

    I'm not sure how the search code works in this scenario - but I wonder if the result is being returned too early before Jason's Onyx updates with the room.

    @TMisiukiewicz I know you did some work on debouncing search in the past, is there anything you might suggest to look for here? Can we make the debounce delay longer for Jason and see if it fixes this?

  7. TMisiukiewicz commented on Feb 10, 2025

    @TMisiukiewicz
    Contributor

    To reproduce it I followed this scenario:

    1. Created workspace with 2 additional members
    2. Created room and invited only 1 additional member
    3. Tried finding it on an account that was not invited to the room but is a member of workspace

    It failed to display the room in the search results, despite:

    • the room was correctly returned by backend
    • the room returned by backend was merged in my Onyx state

    I digged a little bit more and found out that the reason room is not displayed is having notificationPreference set to hidden. For room participants, it is set to daily. When getting search options, we exclude hidden reports so they are not displayed. Not sure what exactly notificationPreference is and how to correctly approach it, any explanation is highly appreciated 🙏

  8. 36 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 14, 2025
  10. changed the title [-][CRITICAL][Search] Unable to discover new rooms via Search[/-] [+][Due for payment 2025-03-21] [CRITICAL][Search] Unable to discover new rooms via Search[/+] on Mar 14, 2025
  11. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-21. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    @allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. mallenexpensify commented on Mar 22, 2025

    @mallenexpensify
    Contributor

    @allroundexperts due $250 via NewDot

    I'm thinking we don't need a test case for this cuz it should already exist or will be created as part of search ones. Comment/reopen if ya disagree.

  16. JmillsExpensify commented on Jun 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Needs ReproductionReproducible steps neededretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions