You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-21] [CRITICAL][Search] Unable to discover new rooms via Search #56583
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@JmillsExpensify Slack conversation (hyperlinked to channel name): Quality
Action Performed:
Open the chat application within the workspace.
Use the search function to look for "Hackathon room".
Observe the search results.
Expected Result:
The Hackathon room should appear in the search results since it exists within the same workspace.
Actual Result:
No results are displayed when searching for Hackathon room, The room is not found despite being a part of the same workspace.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
For the reproduction steps, it's important to note that I'm not a member of this room, so I want to find it and join it, but it never shows up in Search.
I'm not sure how the search code works in this scenario - but I wonder if the result is being returned too early before Jason's Onyx updates with the room.
@TMisiukiewicz I know you did some work on debouncing search in the past, is there anything you might suggest to look for here? Can we make the debounce delay longer for Jason and see if it fixes this?
Tried finding it on an account that was not invited to the room but is a member of workspace
It failed to display the room in the search results, despite:
the room was correctly returned by backend
the room returned by backend was merged in my Onyx state
I digged a little bit more and found out that the reason room is not displayed is having notificationPreference set to hidden. For room participants, it is set to daily. When getting search options, we exclude hidden reports so they are not displayed. Not sure what exactly notificationPreference is and how to correctly approach it, any explanation is highly appreciated 🙏
changed the title [-][CRITICAL][Search] Unable to discover new rooms via Search[/-][+][Due for payment 2025-03-21] [CRITICAL][Search] Unable to discover new rooms via Search[/+]on Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allroundexperts@mallenexpensify@allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 8, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 8, 2025
Triggered auto assignment to @Beamanator (
AutoAssignerNewDotQuality)MelvinBot commentedon Feb 8, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
JmillsExpensify commentedon Feb 8, 2025
For the reproduction steps, it's important to note that I'm not a member of this room, so I want to find it and join it, but it never shows up in Search.
muttmuure commentedon Feb 8, 2025
I'm not sure how the search code works in this scenario - but I wonder if the result is being returned too early before Jason's Onyx updates with the room.
@TMisiukiewicz I know you did some work on debouncing search in the past, is there anything you might suggest to look for here? Can we make the debounce delay longer for Jason and see if it fixes this?
TMisiukiewicz commentedon Feb 10, 2025
To reproduce it I followed this scenario:
It failed to display the room in the search results, despite:
I digged a little bit more and found out that the reason room is not displayed is having
notificationPreferenceset tohidden. For room participants, it is set todaily. When getting search options, we exclude hidden reports so they are not displayed. Not sure what exactlynotificationPreferenceis and how to correctly approach it, any explanation is highly appreciated 🙏36 remaining items
[-][CRITICAL][Search] Unable to discover new rooms via Search[/-][+][Due for payment 2025-03-21] [CRITICAL][Search] Unable to discover new rooms via Search[/+]melvin-bot commentedon Mar 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 14, 2025
@allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 21, 2025
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Mar 22, 2025
@allroundexperts due $250 via NewDot
I'm thinking we don't need a test case for this cuz it should already exist or will be created as part of search ones. Comment/reopen if ya disagree.
JmillsExpensify commentedon Jun 13, 2025
$250 approved for @allroundexperts