You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2025-02-25] [Navigation] Workspace - Unable to invite member from Overview #56797
Version Number: 9.0.98-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sj9032@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Feb 13, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 13, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 13, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 13, 2025
💬 A slack conversation has been started in #expensify-open-source
nkdengineer commentedon Feb 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Nothing happens after clicking Invite button.
What is the root cause of that problem?
We added
Navigation.dismissModal();in this commit to fix error when press ESC buttonbut the problem is that we are using 2 navigates in a row here
App/src/pages/workspace/WorkspaceInviteMessagePage.tsx
Lines 115 to 119 in a0a2609
What changes do you think we should make in order to solve the problem?
We can add
InteractionManager.runAfterInteractionsfor the second navigateApp/src/pages/workspace/WorkspaceInviteMessagePage.tsx
Lines 115 to 119 in a0a2609
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
OR we can remove
Navigation.dismissModal();hereReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
46 remaining items
mountiny commentedon Feb 21, 2025
Looks good to me based on the PR deployment time
zanyrenney commentedon Feb 25, 2025
@nkdengineer i invited you to the upwork job as you had not applied: https://www.upwork.com/ab/applicants/1892145417207271540/pending
nkdengineer commentedon Feb 25, 2025
@zanyrenney Applied to the job, thank you
zanyrenney commentedon Feb 25, 2025
perfect thanks!
zanyrenney commentedon Feb 25, 2025
offer is pending, please accept!
zanyrenney commentedon Feb 25, 2025
cc @nkdengineer
zanyrenney commentedon Feb 26, 2025
payment summary
$250 paid to @nkdengineer via upwork.