Skip to content

[Due for payment 2025-03-03] NSQS Frontend Components: Update approvalAccount selector to be "Payment Account" on the Export Tab #56802

Closed

Description

@yuwenmemon

Tracking Issue: https://github.com/Expensify/Expensify/issues/446352

Design Doc: https://docs.google.com/document/d/18g8cUtqiSwJce2a42d7uU1dLmxz6hjfVf1bIXwyz4PY/


@s77rt As discussed here, let's remove the A/P Approval Account selector in the Advanced Tab. Instead, we should create a "Payment Account" selector that will show the same bank accounts as before (although now they will be stored under paymentAccounts) but in the Export Tab:

Image

Finally, the ID of the selected account should be stored under the key paymentAccount in the config.

Let me know if you have any questions!

Activity

  1. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. removed their assignment
    on Feb 13, 2025
  5. added
    NewFeatureSomething to build that is a new item.
    and removed
    NewFeatureSomething to build that is a new item.
    on Feb 13, 2025
  6. 28 remaining items

  7. yuwenmemon commented on Mar 12, 2025

    @yuwenmemon
    ContributorAuthor

    @maddylewis Can we pay @dukenv0307 for their C+ review of this PR?

  8. maddylewis commented on Mar 14, 2025

    @maddylewis
    Contributor

    yuppp!

  9. maddylewis commented on Mar 14, 2025

    @maddylewis
    Contributor

    @dukenv0307 - will you link me your Upwork profile? thanks!

  10. dukenv0307 commented on Mar 14, 2025

    @dukenv0307
    Contributor

    @maddylewis I will request payment via NewDot

  11. maddylewis commented on Mar 17, 2025

    @maddylewis
    Contributor

    @dukenv0307 @yuwenmemon - will you confirm the payment amount for this issue?

  12. maddylewis commented on Mar 17, 2025

    @maddylewis
    Contributor
  13. maddylewis commented on Mar 18, 2025

    @maddylewis
    Contributor

    just wanna confirm the payment amount - #58522 (comment)

  14. dukenv0307 commented on Mar 19, 2025

    @dukenv0307
    Contributor

    I think the amount should be $250 as usual @yuwenmemon @maddylewis

  15. maddylewis commented on Mar 19, 2025

    @maddylewis
    Contributor

    Payment Details

  16. JmillsExpensify commented on Mar 31, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions