Skip to content

[Navigation] Workspace-Overview page is shown briefly before landing on memebers page when inviting a user #56871

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.98-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #56827
Email or phone of affected tester (no customers): htad26+dfsdjhfjhsdf@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 13/iOS 18.3, Tecno Spark 8/Android 11
App Component: Workspace Settings

Action Performed:

  1. Login with any account
  2. Create a new workspace
  3. Go to workspace settings > Overview>Click Invite
  4. Choose any account > Invite
  5. Observe the page before landing on members page

Expected Result:

User lands on members page after finishing the invite a member flow and the overview page is not shown

Actual Result:

Overview page is shown briefly before the user lands on the members page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6742861_1739535269092.IMG_0834.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @WojtekBoman

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2025
  2. melvin-bot commented on Feb 14, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. M00rish commented on Feb 14, 2025

    @M00rish
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-02-14 23:57:32 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace-Overview page is shown briefly before landing on memebers page when inviting a user

    What is the root cause of that problem?

    this happens because we dismiss the invitation modal before navigating to members page :

    Navigation.setNavigationActionToMicrotaskQueue(() => {
    Navigation.dismissModal();
    InteractionManager.runAfterInteractions(() => {

    What changes do you think we should make in order to solve the problem?

    if we're on small screen we can prevent dismissing the modal and navigate directly to Members Page :

     Navigation.setNavigationActionToMicrotaskQueue(() => {
                if(!isSmallScreenWidth){
                Navigation.dismissModal();
            }
                InteractionManager.runAfterInteractions(() => {
                    Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID));
                });
            });
    

    we could update WORKSPACE_MEMBERS Route to accept a backTo param to make navigation consistent with browser/device back button.

    as if we don't dismiss the modal it will stay in the navigation state leading to inconsistent behaviors so we'll need to clear it out either by clearing the invite screens from navigation or backto param

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    UI issue

    What alternative solutions did you explore? (Optional)

  4. github-actions commented on Feb 14, 2025

    @github-actions
    Contributor

    ⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  5. Kalydosos commented on Feb 14, 2025

    @Kalydosos
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Overview page is shown briefly before landing on memebers page when inviting a user

    What is the root cause of that problem?

    We dismiss the modal here, which pops previous screen before navigating to members page

    Navigation.dismissModal();

    What changes do you think we should make in order to solve the problem?

    As we are navigating to a central screen through a direct route, we can remove the following line

    Navigation.dismissModal();

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  6. self-assigned this
    on Feb 17, 2025
  7. changed the title [-]Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/-] [+][Navigation] Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/+] on Feb 17, 2025
  8. WojtekBoman commented on Feb 17, 2025

    @WojtekBoman
    Contributor

    Hey, I'm going to work on that :)

  9. melvin-bot commented on Feb 21, 2025

    @melvin-bot

    @johncschuster, @mountiny, @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. 7 remaining items

  11. mountiny commented on Mar 2, 2025

    @mountiny
    Contributor

    @WojtekBoman will be back next week

  12. johncschuster commented on Mar 3, 2025

    @johncschuster
    Contributor

    Bumping for Melvin. We're waiting on @WojtekBoman to return from OOO.

  13. WojtekBoman commented on Mar 5, 2025

    @WojtekBoman
    Contributor

    I'm working on it!

  14. WojtekBoman commented on Mar 7, 2025

    @WojtekBoman
    Contributor

    Hey, to fix this issue I need changes from this PR, I'll raise a PR for this issue once the PR I mentioned is merged

  15. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @johncschuster, @mountiny, @WojtekBoman eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  16. mountiny commented on Apr 7, 2025

    @mountiny
    Contributor

    I believe we are good here, no need for regression test as this was just a generic navigation issue and payments handled on the other issue linked to the PR. Thanks!

  17. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.MonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions