You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Navigation] Workspace-Overview page is shown briefly before landing on memebers page when inviting a user #56871
Version Number: v9.0.98-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#56827 Email or phone of affected tester (no customers):htad26+dfsdjhfjhsdf@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 13/iOS 18.3, Tecno Spark 8/Android 11 App Component: Workspace Settings
Action Performed:
Login with any account
Create a new workspace
Go to workspace settings > Overview>Click Invite
Choose any account > Invite
Observe the page before landing on members page
Expected Result:
User lands on members page after finishing the invite a member flow and the overview page is not shown
Actual Result:
Overview page is shown briefly before the user lands on the members page
we could update WORKSPACE_MEMBERS Route to accept a backTo param to make navigation consistent with browser/device back button.
as if we don't dismiss the modal it will stay in the navigation state leading to inconsistent behaviors so we'll need to clear it out either by clearing the invite screens from navigation or backto param
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-]Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/-][+][Navigation] Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/+]on Feb 17, 2025
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
I believe we are good here, no need for regression test as this was just a generic navigation issue and payments handled on the other issue linked to the PR. Thanks!
Activity
melvin-bot commentedon Feb 14, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.M00rish commentedon Feb 14, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-02-14 23:57:32 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace-Overview page is shown briefly before landing on memebers page when inviting a user
What is the root cause of that problem?
this happens because we dismiss the invitation modal before navigating to members page :
App/src/pages/workspace/WorkspaceInviteMessagePage.tsx
Lines 115 to 117 in fe5b1e3
What changes do you think we should make in order to solve the problem?
if we're on small screen we can prevent dismissing the modal and navigate directly to Members Page :
we could update WORKSPACE_MEMBERS Route to accept a backTo param to make navigation consistent with browser/device back button.
as if we don't dismiss the modal it will stay in the navigation state leading to inconsistent behaviors so we'll need to clear it out either by clearing the invite screens from navigation or backto param
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
github-actions commentedon Feb 14, 2025
Kalydosos commentedon Feb 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Overview page is shown briefly before landing on memebers page when inviting a user
What is the root cause of that problem?
We dismiss the modal here, which pops previous screen before navigating to members page
App/src/pages/workspace/WorkspaceInviteMessagePage.tsx
Line 116 in fe5b1e3
What changes do you think we should make in order to solve the problem?
As we are navigating to a central screen through a direct route, we can remove the following line
App/src/pages/workspace/WorkspaceInviteMessagePage.tsx
Line 116 in fe5b1e3
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
[-]Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/-][+][Navigation] Workspace-Overview page is shown briefly before landing on memebers page when inviting a user[/+]WojtekBoman commentedon Feb 17, 2025
Hey, I'm going to work on that :)
melvin-bot commentedon Feb 21, 2025
@johncschuster, @mountiny, @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!
7 remaining items
mountiny commentedon Mar 2, 2025
@WojtekBoman will be back next week
johncschuster commentedon Mar 3, 2025
Bumping for Melvin. We're waiting on @WojtekBoman to return from OOO.
WojtekBoman commentedon Mar 5, 2025
I'm working on it!
WojtekBoman commentedon Mar 7, 2025
Hey, to fix this issue I need changes from this PR, I'll raise a PR for this issue once the PR I mentioned is merged
melvin-bot commentedon Apr 7, 2025
This issue has not been updated in over 15 days. @johncschuster, @mountiny, @WojtekBoman eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mountiny commentedon Apr 7, 2025
I believe we are good here, no need for regression test as this was just a generic navigation issue and payments handled on the other issue linked to the PR. Thanks!