You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-03] Strengthening Regression Coverage in OptionsListUtils Tests #57173
Proposal: Strengthening Regression Coverage in OptionsListUtils Tests
Background:
The OptionsListUtils library provides filtering and ordering capabilities for option lists. Automated reassurance tests are used to verify the correctness of its filterAndOrderOptions function. These tests play a crucial role in catching regressions and maintaining the performance and stability of the function. However, gaps in test coverage may lead to undetected issues, which could affect application behavior in production.
Problem:
Current test cases do not account for scenario when the filterAndOrderOptions processes an empty search value. As a result, regressions related to empty search handling can go unnoticed, which prevents us from ensuring the function's robustness in all edge cases.
Solution:
Add a test case that explicitly verifies how filterAndOrderOptions behaves with an empty search string.
Modify the test configuration for OptionsListUtils.getValidOptions to ensure the tests are more resistant to regression failures.
changed the title [-]Strengthening Regression Coverage in OptionsListUtils Tests[/-][+][Due for payment 2025-03-03] Strengthening Regression Coverage in OptionsListUtils Tests[/+]on Feb 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.4-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 20, 2025
Triggered auto assignment to @slafortune (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.sosek108 commentedon Feb 20, 2025
Hey, its Hubert from Callstack and I would like to work on this issue
ishpaul777 commentedon Feb 21, 2025
👋 @mjasikowski Please assign me here (c+ on #57176)
4 remaining items
[-]Strengthening Regression Coverage in OptionsListUtils Tests[/-][+][Due for payment 2025-03-03] Strengthening Regression Coverage in OptionsListUtils Tests[/+]melvin-bot commentedon Feb 24, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.4-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 24, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ishpaul777 commentedon Feb 24, 2025
No regression test needed, the PR does not introduce any new features, only added the automated tests
slafortune commentedon Mar 3, 2025
@sosek108 Role Contributor - does not require payment (Contractor)
@ishpaul777 Role C+ - requires $250 payment through NewDot Manual Requests
garrettmknight commentedon Mar 11, 2025
$250 approved for @ishpaul777