Skip to content

[Due for payment 2025-03-03] Strengthening Regression Coverage in OptionsListUtils Tests #57173

Closed

Description

@mountiny

Proposal: Strengthening Regression Coverage in OptionsListUtils Tests

Background:

The OptionsListUtils library provides filtering and ordering capabilities for option lists. Automated reassurance tests are used to verify the correctness of its filterAndOrderOptions function. These tests play a crucial role in catching regressions and maintaining the performance and stability of the function. However, gaps in test coverage may lead to undetected issues, which could affect application behavior in production.

Problem:

Current test cases do not account for scenario when the filterAndOrderOptions processes an empty search value. As a result, regressions related to empty search handling can go unnoticed, which prevents us from ensuring the function's robustness in all edge cases.

Solution:

  • Add a test case that explicitly verifies how filterAndOrderOptions behaves with an empty search string.
  • Modify the test configuration for OptionsListUtils.getValidOptions to ensure the tests are more resistant to regression failures.
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. sosek108 commented on Feb 20, 2025

    @sosek108
    Contributor

    Hey, its Hubert from Callstack and I would like to work on this issue

  3. ishpaul777 commented on Feb 21, 2025

    @ishpaul777
    Contributor

    👋 @mjasikowski Please assign me here (c+ on #57176)

  4. 4 remaining items

  5. changed the title [-]Strengthening Regression Coverage in OptionsListUtils Tests[/-] [+][Due for payment 2025-03-03] Strengthening Regression Coverage in OptionsListUtils Tests[/+] on Feb 24, 2025
  6. melvin-bot commented on Feb 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Feb 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.4-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
    • @ishpaul777 requires payment through NewDot Manual Requests
  8. melvin-bot commented on Feb 24, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  9. ishpaul777 commented on Feb 24, 2025

    @ishpaul777
    Contributor

    [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

    No regression test needed, the PR does not introduce any new features, only added the automated tests

  10. slafortune commented on Mar 3, 2025

    @slafortune
    Contributor

    @sosek108 Role Contributor - does not require payment (Contractor)
    @ishpaul777 Role C+ - requires $250 payment through NewDot Manual Requests

  11. garrettmknight commented on Mar 11, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions