You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-21] [$250] Expense - Total amount and pay button reload each time any field other than amount is edited #57530
Version Number: 9.1.7-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+270205kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Delayed submissions and Add approval are disabled
Workspace has no unsettled expense.
Go to staging.new.expensify.com
Go to workspace chat
Submit a manual expense with currency that is not the default workspace currency.
Go to expense report.
Click any field other than Amount (description, merchant or date).
Edit the amount and save it.
Expected Result:
Total amount and pay button will not reload each time any field other than amount is edited because amount is not modified.
Actual Result:
Total amount and pay button reload each time any field other than amount is edited.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Write test for calculateDiffAmount to cover:
Different currency
Different amount
Same currency
Same amount
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Total amount and pay button reload each time any field other than amount is edited[/-][+][$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/+]on Mar 5, 2025
changed the title [-][$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/-][+][Due for payment 2025-03-21] [$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/+]on Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ishpaul777@kadiealexander@ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not critical. does not block any functionality only a loading indicator till request success
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - would be good to add test
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 27, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Feb 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Total amount and pay button reload each time any field other than amount is edited.
What is the root cause of that problem?
When we update the description or date, ... we will get the
calculatedDiffAmountApp/src/libs/actions/IOU.ts
Lines 3486 to 3487 in 0856182
calculatedDiffAmountis null in this case because the currency is different from iouReport's currencyApp/src/libs/actions/IOU.ts
Line 3341 in 0856182
So isTotalIndeterministic is true
then we add pendingFields for total
App/src/libs/actions/IOU.ts
Line 3527 in 0856182
If the total is pending we'll show the loading indicator
What changes do you think we should make in order to solve the problem?
We should update
calculateDiffAmountfunction to checkupdatedCurrency === currentCurrency && currentAmount == updatedAmountthen return 0What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Write test for
calculateDiffAmountto cover:What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Mar 4, 2025
@kadiealexander Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Mar 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021897119097792368103
[-]Expense - Total amount and pay button reload each time any field other than amount is edited[/-][+][$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/+]melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)22 remaining items
[-][$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/-][+][Due for payment 2025-03-21] [$250] Expense - Total amount and pay button reload each time any field other than amount is edited[/+]melvin-bot commentedon Mar 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 14, 2025
@ishpaul777 @kadiealexander @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
kadiealexander commentedon Mar 20, 2025
Payments needed:
@ishpaul777 could you please do the checklist?
ishpaul777 commentedon Mar 23, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/56793/files#r2009219945
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not critical. does not block any functionality only a loading indicator till request success
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - would be good to add test
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/483646
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
kadiealexander commentedon Mar 24, 2025
Payment summary here.
garrettmknight commentedon May 2, 2025
$250 approved for @ishpaul777